-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax restrictions on sideloaded game titles #3757
Comments
Also I want to add that the game Title for Sideloaded games has a character limit, which makes it hard to add games like: "Shadow Tactics: Blades of the Shogun - Aiko's Choice" Can the prefix folder and the game Title be different? |
I faced both problems mentioned above. Would love to see this improvement implemented. |
I wondering about the same. I found that the title value is limited to 40 characters: HeroicGamesLauncher/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx Line 314 in ac0a8ef
Not sure if there is a strong reason for this or if it was an arbitrary value selected at the time of implementing the sideload games feature (the title must have a max length although 40 seems to be a bit low to me) and was not revisited. I suppose the idea of having the game directory name matching the game title make things more intuitive for the user, although it has the problems mentioned in this issue. It would be great to hear from the team about this, based on their feedback I can work on a PR to address the problems reported in this issue. |
Problem description
Right now, sideloaded game titles cannot contain several special characters:
HeroicGamesLauncher/src/frontend/screens/Library/components/InstallModal/SideloadDialog/index.tsx
Line 69 in ac0a8ef
This is a bit surprising since non-sideloaded games don't have that restriction. For example,
+
is not allowed, even though my non-sideloaded copy ofCave Story+
is listed without issue.Feature description
It would be nice to lift this restriction. The title can always be sanitized elsewhere as needed, like for folder names (or that could use the auto-generated
app_name
).Alternatives
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: