-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation questions #31
Comments
Hello. Many thanks for the detailed examples and comments.
I will be glad to accept your PR on the first and second points, or I will do it myself in the future. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, thanks for the great job. I have noticed several problems
My solution:
After that the memory ceased to disappear. This helped free up memory.
https://github.com/HavenDV/H.Pipes/blob/0db095207ddfabfabb4a2c74f34ece8c26962e0b/src/libs/H.Pipes/PipeServer.cs#LL182C33-L182C33
Then the break stops the while cycle. New clients can no longer connect to the server.
https://github.com/HavenDV/H.Pipes/blob/0db095207ddfabfabb4a2c74f34ece8c26962e0b/src/libs/H.Pipes/PipeServer.cs#LL195C25-L195C25
My solution:
replace
break;
tothrow;
Question: How reasonable was the break in this place? Is my fix correct or should this cycle be created per client?
this code looks cleaner and easier to maintain. Same with WriteAsync.
The text was updated successfully, but these errors were encountered: