Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variable naming. #1

Open
HarshKapadia2 opened this issue May 15, 2022 · 7 comments
Open

Improve variable naming. #1

HarshKapadia2 opened this issue May 15, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@HarshKapadia2
Copy link

HarshKapadia2 commented May 15, 2022

Nice Action!

In my opinion, variables like prbody, prurl and PRNUM would be more readable if they had underscores (_) or hyphens (-) to separate them.

prurl ➡️ pr-url (underscore didn't look good to me here)
prbody ➡️ pr-body (underscore didn't look good to me here)
PRNUM ➡️ PR_NUM (hyphen didn't look good to me here)

Cc: @tusharnankani

@HarshCasper
Copy link
Owner

Hi @HarshKapadia2 @tusharnankani 👋

Thanks for the suggestions! Would you like to submit a PR for any of this? I would be obliged for the purpose 😄

@HarshCasper HarshCasper added the enhancement New feature or request label May 15, 2022
@HarshKapadia2
Copy link
Author

Sure @HarshCasper, I wouldn't mind submitting a PR. I'll do it on the 17th if that's okay with you, as I have end semester exams going on. Sorry!

@HarshCasper
Copy link
Owner

Sure @HarshCasper, I wouldn't mind submitting a PR. I'll do it on the 17th if that's okay with you, as I have end semester exams going on. Sorry!

Please take your time! Best of luck with your exams :)

@HarshKapadia2
Copy link
Author

Hey @HarshCasper I was working on this issue, but I had a doubt. Where are the following environment variables being set?

body = os.getenv("INPUT_PRBODY")
url = os.getenv("INPUT_PRURL")

I'm asking because I want to rename them to INPUT_PR_BODY and INPUT_PR_URL, but wasn't sure where they're being set. It might cause errors if I rename them without knowing how they're set. I couldn't find anything in the docs. Maybe I missed it.

@HarshKapadia2
Copy link
Author

Hey @HarshCasper any updates?

@HarshCasper
Copy link
Owner

Hi @HarshKapadia2 — Apologies for the late response.

Here are the references:

body = os.getenv("INPUT_PRBODY")

I hope it makes sense now. Please let me know if you have any further questions and I will respond over quickly (subscribed to this conversation).

@Ismoh
Copy link
Contributor

Ismoh commented Oct 27, 2022

Any news on this? @HarshKapadia2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants