Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script and description added #1393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Script and description added #1393

wants to merge 2 commits into from

Conversation

TheBugYouCantFix
Copy link

@TheBugYouCantFix TheBugYouCantFix commented Jun 15, 2022 •
edited

Description

This is a simple script that sorts the files from a given directory by their extensions.

Fixes #1392

Replace issue_no with the issue number which is fixed in this PR

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@github-actions
Copy link

PR is not linked to any issue, please make the corresponding changes in the body. The issue should look like this. For help follow this link

@ghost
Copy link

ghost commented Jun 15, 2022 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ClasherKasten
ClasherKasten reviewed Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@ClasherKasten ClasherKasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comment i made. Other than that this looks OK to me.

Python/File_Sort/main.py
"""getting all the files that have been put to the sorting folder by user and
extending them to our files list to sort them in the future"""

files.extend(list(os.walk(source_path))[0][2]) # extending the list of all the files in a source path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has problems when the input is a ..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just pushed a new commit fixing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClasherKasten ClasherKasten ClasherKasten approved these changes

@RohiniRG RohiniRG Awaiting requested review from RohiniRG

@sohamsshah sohamsshah Awaiting requested review from sohamsshah

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[script request]:
2 participants
@TheBugYouCantFix @ClasherKasten