Windows-GUI: Chapter name by source media with more than one chapter will not translated to configured language

[hnsteyding]

Problem Description

Source media with more than one Chapter are always viewed in english language in HB

With 1 chapter it's OK:

Another language:

With more chapters it's always in english:

Another language:

Activity Log, Crash Log or any other details

See screenshots

What Operating System are you running?

Windows 10

What version of HandBrake are you running?

github master

Where did you download HandBrake from?

github

[sr55]

Chapter names are passed though from source. If we get an empty track name or the source simply doesn't have chapters, it defaults it and the string for that which is translated.

[hnsteyding]

"If we get an empty track name or the source simply doesn't have chapters, it defaults it and the string for that which is translated."

But this happens only if source has no or only one chapter.
This must/should be also happend/translated if i use german/spanish etc. GUI language.

"Chapter names are passed though from source...."

I've checked this with DVD who contains a german movie and which was produced and released in germany, but still get only english instead of german/spanish language.

And If a/this DVD has empty track names it should show configured GUI language as default.

Or i did not understand your comment... :(

[sr55]

hmm, did a little more digging. It Looks like libhb generates the name in dvd.c. Unfortunately libhb isn't translatable and the UI has no-way of knowing this isn't coming from the source.

@galad87 @jstebbins Thoughts on removing this and letting the UI set the name in the native language instead? Would need to think about the CLI as well.

Edit: Looks like bd.c does the same.

[jstebbins]

I'm thinking the better thing would be to add a flag to hb_chapter_t to indicate that no chapter name was available in the source. That way we can distinguish a name intentionally left blank from one that was not present in the source. And we can leave the current default initialization, letting UIs override if they want. E.g. the CLI also is not translated and wouldn't really need extra code to initialize the chapter list.

[sr55]

Yeh, that would work.