Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSource gives TypeError in Internet Explorer 11 #88

Open
fredriksundstrom opened this issue Mar 9, 2020 · 1 comment
Open

isSource gives TypeError in Internet Explorer 11 #88

fredriksundstrom opened this issue Mar 9, 2020 · 1 comment
Labels

Comments

@fredriksundstrom
Copy link

fredriksundstrom commented Mar 9, 2020

We have quite a few users in Internet Explorer 11 still and we started using ngx-avatar recently. We detected that it throws a typeerror on the isSource method:

return this.avatarSources.includes(source as AvatarSource);

We use the initials version only.

It pauses loading of polyfills which is a big deal with IE so ngx-avatar (or an error we did with ngx-avatar) is causing some issues. :)

TypeError: Object doesn't support property or method 'includes' at AvatarService.prototype.isSource (http://192.168.20.61:4200/vendor.js:173933:5) at AvatarComponent.prototype.ngOnChanges (http://192.168.20.61:4200/vendor.js:174083:9) at checkAndUpdateDirectiveInline (http://192.168.20.61:4200/vendor.js:83556:5) at checkAndUpdateNodeInline (http://192.168.20.61:4200/vendor.js:84824:9) at checkAndUpdateNode (http://192.168.20.61:4200/vendor.js:84786:5) at debugCheckAndUpdateNode (http://192.168.20.61:4200/vendor.js:85420:1) at debugCheckDirectivesFn (http://192.168.20.61:4200/vendor.js:85380:9) at Anonymous function (Function code:34:5) at debugUpdateDirectives (http://192.168.20.61:4200/vendor.js:85372:1) at checkAndUpdateView (http://192.168.20.61:4200/vendor.js:84768:1)

We use it just like this:

<ngx-avatar size="42" [name]="session.user.Name"></ngx-avatar> and <ngx-avatar size="48" src="{{ data.senderLogoImage }}"></ngx-avatar>

Any help would be appreciated!

@odahcam odahcam added the bug label Apr 10, 2020
@odahcam
Copy link
Collaborator

odahcam commented Apr 10, 2020

That makes perfect sense, have you tried loading a polyfill on IE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants