Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 12 #125

Open
mhosman opened this issue May 19, 2021 · 27 comments
Open

Update to Angular 12 #125

mhosman opened this issue May 19, 2021 · 27 comments

Comments

@mhosman
Copy link

mhosman commented May 19, 2021

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.1.0" from [email protected]
npm ERR! node_modules/ngx-avatar
npm ERR!   ngx-avatar@"^4.1.0" from the root project
@mhosman
Copy link
Author

mhosman commented Jul 12, 2021

Any update?

@g-max
Copy link

g-max commented Jul 23, 2021

@mhosman i'm waiting for update from developers too, but what i've noticed is that 4.1.0 works fine with ng12, so we decided to do npm install --force and just wait for ngx-avatar to be updated

@dillonledoux
Copy link

Is there any update on this or something that can be contributed to to help it along?

@mhosman
Copy link
Author

mhosman commented Sep 1, 2021

We are gonna hit Angular 13 in the next days and this is still stucked in version 11. Any news? I don't know if @PowerKiKi @Heatmanofurioso have access. Thanks!

@PowerKiKi
Copy link
Contributor

I gave up on this project, and I am now using my own fork (very simplified and part of a larger library that I would not recommend to use by external people).

I can confirm, from npm settings, that odahcam, hmosbahi and heatmanofurioso all have write access. Even though this project is relatively low maintenance, it seems that it is having a hard time to find regular contributors. Maybe adding one more person would help ?

@Heatmanofurioso
Copy link

I did not get write permissions, I can't merge the PRs. Still, I believe only HaithemMosbahi can publish to npm even if we are given write permissions

I did make a fork of this project due to it being inactive a while ago if you guys recall it.. I would much prefer to contribute on this one than to work on my forked version though.

That being said, I am going to work on it and recommend it if no one can maintain this one.
I am more than willing to actively maintain it if necessary. What do you guys think @PowerKiKi @mhosman ?

@mhosman
Copy link
Author

mhosman commented Sep 2, 2021

Thank you very much for the reply @Heatmanofurioso
If @HaithemMosbahi does not give the write permissions I think it is best to make a definitive fork since we have no answers. In case these permissions are not given, it is best to create a new fork with permissions to two or three people and in case someone cannot update the code, another could.

@Heatmanofurioso
Copy link

Heatmanofurioso commented Sep 2, 2021

There's no need to make a new one I believe @mhosman
I am more than willing to give all necessary permissions to a couple of people on my fork.
It's already published on npm under ngx-avatars

That fork was made explicitly with the intention of it being a continuation of ngx-avatar, since it couldn't be actively maintained

Edit:
I will also make an effort to ensure I make a release every minor version at least, and not only on the major versions, to ensure that people have compatible versions to their specific needs

@PowerKiKi
Copy link
Contributor

I've said it before, but the sooner there is an "official" fork, the better. We've been trying for years now. It's time to move on. To another repo. @Heatmanofurioso's one looks like the obvious choice.

@HaithemMosbahi
Copy link
Owner

Hello,
I thought that I gave all the needed access ( GitHub and npm ) to build and publish the library. If I remember correctly 3 people were added as maintainers.
I didn’t follow the last discussion, is there anything I can help with in regards to permission ?

@Heatmanofurioso
Copy link

Hi @HaithemMosbahi Thanks for replying! For some reason, I seem to not have permissions to merge PRs.

Could you give it a look so we can update the project to support V12 and so on here on Github please?

@mhosman
Copy link
Author

mhosman commented Sep 4, 2021

@HaithemMosbahi I think @Heatmanofurioso has no access to merge PR's. Thats the issue

@Heatmanofurioso
Copy link

Hi @HaithemMosbahi. Sorry to bother, but a few days have passed. Could you please give a look into it?

@neryortez
Copy link

Soooo..... No answer?

@Heatmanofurioso
Copy link

Until we can actually update this project consistently.. I have kept my fork up to date, and intend to keep doing so in case anyone is interested in it.

It is in the npm registry also

@Heatmanofurioso
Copy link

Angular 13 is a week away from launching and the project still doesn't support 12.

@mhosman
Copy link
Author

mhosman commented Oct 26, 2021

@HaithemMosbahi please can you give the permissions to @Heatmanofurioso to merge PR's? Thanks!

@Lyro1
Copy link

Lyro1 commented Oct 31, 2021

I usually use this component for most of my angular projects. The lack of support of Angular 12 is really disappointing, even more so with the work being already done by @Heatmanofurioso... Please @HaithemMosbahi give him the permissions to merge PR's.

@bhalperin
Copy link

Is it a dead end?
@HaithemMosbahi can you please update?

@Heatmanofurioso
Copy link

@bhalperin For now, while Haithem doesn't update the project, you can use my fork.
It's being maintained and updated regularly when new Angular versions come out

@PowerKiKi
Copy link
Contributor

At this point, the whole community should migrate to https://github.com/Heatmanofurioso/ngx-avatars.

@codingsamuel
Copy link

There is already a pr for Angular 13. Is there any update on this? #138

@PowerKiKi
Copy link
Contributor

@codingsamuel don't wait for anything from this project, and just move to https://github.com/Heatmanofurioso/ngx-avatars

@sujeetjaiswara
Copy link

When angular 13 support coming ?

@Heatmanofurioso
Copy link

Heatmanofurioso commented Jan 17, 2022

It unfortunately probably isn't coming @sujeetjaiswara
Read this convo, as we've made a fork/alternative
https://github.com/Heatmanofurioso/ngx-avatars

@sujeetjaiswara
Copy link

Okay, Thanks @Heatmanofurioso 😀

@vzakharov-rxnt
Copy link

What was the issue? I'm using it with Angular 13, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests