Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 10.x #116

Open
rolfback opened this issue Oct 30, 2020 · 15 comments
Open

Support for Angular 10.x #116

rolfback opened this issue Oct 30, 2020 · 15 comments

Comments

@rolfback
Copy link

npm WARN [email protected] requires a peer of @angular/common@^9.0.0 but none is installed.

Works fine with Angular 10.x.

@odahcam
Copy link
Collaborator

odahcam commented Oct 30, 2020

Related: #108

@mhosman
Copy link

mhosman commented Nov 26, 2020

Angular 11.....

@odahcam
Copy link
Collaborator

odahcam commented Dec 7, 2020

PRs still welcome guys. Don't forget there are ready to merge PRs that still didn't got merged because we can't currently deploy a new version.

@OldShaterhan
Copy link

I'm waiting for update too. It looks to work with Angular 11.

@odahcam
Copy link
Collaborator

odahcam commented Jan 27, 2021

@OldShaterhan with the current version?

@OldShaterhan
Copy link

@odahcam yup, 11.1.1. Probably only change that should be done is package version compatibility and ES target platform (as far as I remember).

@Heatmanofurioso
Copy link

This issue could be closed, since support has been added with
#119

@odahcam
Copy link
Collaborator

odahcam commented Jan 28, 2021

No, it didn't. The PR was merged but the package was not released, so we still do not have support for Angular 10 unless you build from sources.

@mhosman
Copy link

mhosman commented Jan 28, 2021

It should be great to give access to any other collaborator to publish new packages

@odahcam
Copy link
Collaborator

odahcam commented Jan 29, 2021

Yes it should.

@Heatmanofurioso
Copy link

This issue can be closed, as the support has been added

@Heatmanofurioso
Copy link

@rolfback Can you close the issue since Haithem doesn't seem to be active in the repo anymore, please?

@iSatishYadav
Copy link

iSatishYadav commented Jul 6, 2023

I am at Angular 10 and can't install with following error:

> npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^10.2.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^9.0.0" from [email protected]
npm ERR! node_modules/ngx-avatar
npm ERR!   ngx-avatar@"4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Can't upgrade my Angular to 11 for now, any help is appreciated.

My deps are as follows:

 "dependencies": {
    "@angular/animations": "^10.2.5",
    "@angular/common": "^10.2.5",
    "@angular/compiler": "^10.2.5",
    "@angular/core": "^10.2.5",
    "@angular/forms": "^10.2.5",
    "@angular/platform-browser": "^10.2.5",
    "@angular/platform-browser-dynamic": "^10.2.5",
    "@angular/platform-server": "^10.2.5",
    "@angular/router": "^10.2.5",
    "core-js": "^3.8.3",
    "ngx-avatar": "4.0.0",
    "popper.js": "^1.16.0",
    "rxjs": "^6.6.3",
    "tslib": "^2.0.0",
    "zone.js": "~0.10.2"
  },

@OldShaterhan
Copy link

@iSatishYadav, see ngx-avatars on npmjs.

@iSatishYadav
Copy link

@iSatishYadav, see ngx-avatars on npmjs.

Apologies. Blunder at my end. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants