Do not load the payments scripts until actually needed

[negue]

I saw that on a normal page (nothing with subscription or anything) stripe and amazon pay was loaded

This needs to be pushed to a point where we actually need em

[lstanford53]

@negue Hello, I'd be willing to investigate this a bit and see what I can find. Could you let me know the page you were on when stripe and amazon pay were loaded? Was it the home page or another page?

[CuriousMagpie]

Hi @lstanford53--let's get your other two PRs into production first before adding something else to your plate. The team also needs to do more investigation on this issue to determine the scope of the fix needed--it may be something we prefer to handle internally.

[dsychin]

I'm not sure about Amazon pay but Stripe recommends adding their JS on all pages for fraud detection.

To best leverage Stripe’s advanced fraud functionality, include this script on every page, not just the checkout page. This allows Stripe to detect suspicious behavior that may be indicative of fraud as customers browse your website.

[negue]

Sorry for the way to late response on this:

@negue Hello, I'd be willing to investigate this a bit and see what I can find. Could you let me know the page you were on when stripe and amazon pay were loaded? Was it the home page or another page?

the file that is always adding the scripts: client/src/lib/payment.js, sure those are at least marked as lazy, but I'd rather save some bytes for each site call 😬

I'm not sure about Amazon pay but Stripe recommends adding their JS on all pages for fraud detection.

To best leverage Stripe’s advanced fraud functionality, include this script on every page, not just the checkout page. This allows Stripe to detect suspicious behavior that may be indicative of fraud as customers browse your website.

Oh, thats good to know - we might need to investigate that further and see what Amazon recommends, maybe that one can be only used on the page it is actually used

We'll need to discuss this internally before continuing on this one