Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14349 - Fixed group creation on Docker by updating to Mongo 4.2.8 replica set #14421

Closed

Conversation

alexiswatson
Copy link

Fixes #14349

Changes

  • Updated mongo image in docker-compose.dev to 4.2.8
  • Converted Mongo instance from standalone to replica set
  • Added mongo-init.js script to initialize replica set

UUID: 973e45cb-ff63-40ae-ac99-9538871b0941

@alexiswatson
Copy link
Author

Note that some of the linting doesn't really apply here, based on the execution environment of mongo-init.js (ex: sleep() is very much a thing). As the wiki mentions, other tests don't reliably run in Docker, so I'd be happy to review the results here (perhaps tackling that in a separate issue).

@alexiswatson
Copy link
Author

It occurs to me that as a first-time contributor, an admin would need to approve running the workflows here. If one wouldn't mind kicking things off (with the above caveats), I'd be happy to help close this out!

@alexiswatson
Copy link
Author

As mentioned above, this code runs in Mongo's execution context. rs and sleep are very much defined. This leaves:

Error: 5:1 error Expected an assignment or function call and instead saw an expression no-unused-expressions

If the expression conditional syntax is an issue here, happy to change it, but before I do I'd appreciate confirmation from a maintainer that we can either suppress or ignore the other linting here.

Looking forward to getting this merged!

@ychisbest
Copy link

help a lot,thanks very much!!!

@CuriousMagpie
Copy link
Member

We're now using Mongo version 5.0.23, so I'm closing this. If you're still having a problem, please open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create party or guild on local docker install
3 participants