Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): corrects crowding in drawer title that obstructs drawer toggle icon on mobile website #14368

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AlexKliger
Copy link

Fixes #13914

Changes
Currently, when viewing the drawer UI in the shop on mobile, the drawer tabs crowd and obstruct the toggle drawer icon. This occurs because styling for full-screen prevents the left side of the drawer from taking up available space. This pull adds an additional media query to the drawer component to make it more responsive on mobile.

Before
160884995-6dd6c86f-50c6-429e-996e-4a7b1a2df38d

After
89512733827589


UUID: 20dcb998-4ae9-4985-8b1d-d56c12479ec2

@AlexKliger
Copy link
Author

I'm a first time contributor so the workflow for tests hasn't run automatically. Can an admin click the button to start it please?

@AlexKliger AlexKliger changed the title fix(ui): correct crowding in title of drawer component that causes drawer toggle icon to become obstructed on mobile website fix(ui): corrects crowding in drawer title that obstructs drawer toggle icon on mobile website Nov 19, 2022
@SabreCat
Copy link
Member

Hi @AlexKliger, thanks for submitting this!

Would you be willing to do a little bit more style cleanup while you're touching this component?

  • Center the "what does my pet like to eat" text and "you don't have any" bubble within the containing div
  • Give "what does my pet like to eat" sufficient space to avoid wrapping with the default English text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with opening and closing the item drawer on smaller screens
2 participants