Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with opening and closing the item drawer on smaller screens #13914

Open
Tressley opened this issue Mar 30, 2022 · 14 comments · May be fixed by #14368
Open

Issue with opening and closing the item drawer on smaller screens #13914

Tressley opened this issue Mar 30, 2022 · 14 comments · May be fixed by #14368

Comments

@Tressley
Copy link
Collaborator

On the mobile browser version of Habitica, the item drawer close icon is inaccessible due to tabs overlaying the control.

image

@vanessasickles
Copy link

@Tressley I'd love to take on this one!

@Tressley
Copy link
Collaborator Author

@vanessasickles -- Thank you!

@vanessasickles
Copy link

Reposting my Blacksmith's Guild message:

My local setup started out pretty smoothly. I followed the documentation here: https://habitica.fandom.com/wiki/Setting_up_Habitica_Locally_on_Windows All went well until the last step of running "npm run client:dev". This is my error:

'vue-cli-service' is not recognized as an internal or external command, operable program or batch file.

I have three integrated terminals (on Windows, so PowerShells) running in Visual Studio Code. First one properly is running the Mongo instance, matching the desired logging output. Second one is properly showing as "connected with mongoose", matching the desired logging output. However, in my third terminal, upon running npm run client:dev, it immediately breaks with the above error.

Any hints or help? Thanks so much in advance!

@Tressley @CuriousMagpie (hope the tag is ok, let me know if not!)

@Tressley
Copy link
Collaborator Author

Tressley commented Apr 6, 2022

Tagging in @SabreCat to see if he can provide any guidance.

@vanessasickles
Copy link

vanessasickles commented Apr 9, 2022

I revisited this and decided to just try continuing to npm install missing packages until it stopped returning them.

Through this chain, I npm installed:

  • vue-cli-service
  • @vue/cli-plugin-babel
  • @vue/cli-plugin-eslint
  • @vue/cli-plugin-unit-mocha
  • vue-cli-plugin-storybook
  • @storybook/core/server

The @storybook/core/server is where I got caught, because npm install @storybook/core/server yields no package.json -- Could not install from "@storybook\core\server" as it does not contain a package.json file.

I'd really like to resolve this issue so I can help contribute! If anyone has any advice, please let me know!

@Tressley
Copy link
Collaborator Author

Tressley commented Apr 9, 2022

@negue -- Are you familiar with this issue? It's related to Storybook.

@negue
Copy link
Member

negue commented Apr 9, 2022

@vanessasickles Could it be that you not ran npm install in the website/client folder?

We have the server one in / (root of the repo) and website/client for the client - both need to be installed.

I think after that it should work.

as for the npm install @storybook/core/server npm packages can be only installed with using a name or @org/name sub entries like /server are not packages anymore - just the content of that package

@vanessasickles
Copy link

Thank you for the feedback! Deeply sorry that I didn't see this response until now, I'll try this the next time I sit down to work on this! Appreciate it!

@CuriousMagpie
Copy link
Member

@vanessasickles Hi there! Were you able to resolve your local installation issues?

@vanessasickles
Copy link

@CuriousMagpie Thanks for checking in! I haven't gotten to revisit this yet, but it's back on my radar now. Thanks so much!

@CuriousMagpie
Copy link
Member

Hey @vanessasickles! Checking in on this again--are you making any progress?

@AlexKliger
Copy link

Hi @CuriousMagpie. Wanted to know if I could try to resolve this issue?

@AlexKliger
Copy link

Hey @CuriousMagpie,

Just wanted to follow up on this issue and request to work on it again as per the Blacksmith guidelines. I feel that it would be a good first contribution and I believe that I have already found the solution.

@CuriousMagpie
Copy link
Member

Hi @AlexKliger, I've gone ahead and reassigned this to you since we haven't heard from @vanessasickles in a while. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment