Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you re-write such "crop" function ? #85

Open
MengHao666 opened this issue Apr 19, 2022 · 1 comment
Open

Why do you re-write such "crop" function ? #85

MengHao666 opened this issue Apr 19, 2022 · 1 comment

Comments

@MengHao666
Copy link

MengHao666 commented Apr 19, 2022

First thanks for such great work.
I found the crop function here is so different from the original code here. What is the purpose for such changes. As our own data would go here and failed to get properly cropped image finally.

@anjany
Copy link

anjany commented Aug 10, 2022

Hi @MengHao666 : Were you able to figure out what the bug was? I think I have the same question as I face this issue #56. Everything seems to be working if I copy the old crop function you linked to (or crop_v2 in current branch). Is this the same for you?

Interestingly, the problem doesn't occur on all the images that go here though, and I'm not able to figure out what is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants