Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot exit Thumbnail mode on Linux #505

Open
1 task done
matbgn opened this issue Apr 13, 2024 · 4 comments · May be fixed by #512
Open
1 task done

[Bug] Cannot exit Thumbnail mode on Linux #505

matbgn opened this issue Apr 13, 2024 · 4 comments · May be fixed by #512
Labels
bug Something isn't working Linux Something related to Linux operating system
Milestone

Comments

@matbgn
Copy link

matbgn commented Apr 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

What's the problem?

Minimize works but maximize back isn't working.

See vidéo below:

record-2024-04-13_18-03-48.mp4

How did you install the app?

downloaded one of the provided packages

Operating System

Linux

Additional context

No response

@matbgn
Copy link
Author

matbgn commented Apr 13, 2024

Just adding a comment Off-Topic to give you a lot of kudos for the UI refactoring!!! You've done an amazing work.

PS: note that this issue is non-blocking, so take your time to fix it.

@GyulyVGC
Copy link
Owner

Hey @matbgn thanks so much for the kudos, I really appreciate you like it 😄


The problem

This annoying issue seems to happen only in some Linux systems, and it's due to the fact that when thumbnail mode is active click events on the window may indicate that the user started grabbing it.

While Windows and macOS correctly distinguish when the user clicked on the "maximise" button, in Linux this action is interpreted as a click to start dragging the thumbnail (some environments require a double click to work, while in other cases as yours it's not possible even with multiple clicks).


Possible solutions

  • A possible workaround I can think of is to add a keyboard shortcut to enter/exit thumbnail mode, so users with this issue can simply focus the app window and press the shortcut key to maximise it back
  • Since the previous point is not a real solution to the main problem, the best strategy would be to set the drag hook for the window excluding the portion where the "maximise" button is... but I'm currently not aware about how to tell Iced to listen to drag events only for a given portion of the window

@GyulyVGC GyulyVGC added bug Something isn't working Linux Something related to Linux operating system labels Apr 13, 2024
@GyulyVGC GyulyVGC changed the title [Bug] Maximize the window is not possible after Minimize on Linux Desktop [Bug] Cannot exit Thumbnail mode on Linux Apr 13, 2024
@Digitalone1
Copy link
Contributor

For what it's worth, it works in Gnome Wayland, but only if I double click on the thumbnail icon.

@GyulyVGC
Copy link
Owner

I've come up with a possible solution for this issue: the drag action is now set to require a double click, so that a single click won't be captured as a drag beginning, thus allowing for it to be correctly identified as a simple button click.
Feel free to let me know your thoughts.

@GyulyVGC GyulyVGC linked a pull request Apr 19, 2024 that will close this issue
3 tasks
@GyulyVGC GyulyVGC added this to the v1.3.1 milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Something related to Linux operating system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants