-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighthouse score for GWT-Material apps decreased due to unload listener in older embedded JQuery #1043
Comments
Nice catch will check into it
…On Wed, 21 Feb 2024, 12:47 pm Garth Henning, ***@***.***> wrote:
Google Lighthouse now scores use of an unload listener poorly for their
"Best Practices" score.
https://web.dev/articles/bfcache?utm_source=lighthouse&utm_medium=devtools#never_use_the_unload_event
GWT-Material v2.8.3 has an embedded dependency on JQuery v3.5.1. JQuery
v3.5.1 attaches unload listeners. JQuery corrected this in v3.7.1.
jquery/jquery#5323
Updating the embedded JQuery would mean web sites using GWT-Material no
longer get their scores decremented.
—
Reply to this email directly, view it on GitHub
<#1043>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAX6EF6BUDNCT3BJJ7LBYRDYUV37RAVCNFSM6AAAAABDSLEFY6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DKOBSGY2DSMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Google Lighthouse now scores use of an unload listener poorly for their "Best Practices" score.
GWT-Material v2.8.3 has an embedded dependency on JQuery v3.5.1. JQuery v3.5.1 attaches unload listeners. JQuery corrected this in v3.7.1.
Updating the embedded JQuery would mean web sites using GWT-Material no longer get their scores decremented.
The text was updated successfully, but these errors were encountered: