Fix problems with deleted recent activity items, which do not have ti… #19394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingzacko1
approved these changes
May 20, 2024
janheise
approved these changes
May 21, 2024
|
@luk-kaminski I think we should backport this? |
Yeah, I believe so. |
luk-kaminski
deleted the
fix/recent_activity_misses_activity_on_deleted_items
branch
9 tasks
ousmaneo
pushed a commit
that referenced
this pull request
May 24, 2024
ousmaneo
pushed a commit
that referenced
this pull request
May 29, 2024
ousmaneo
pushed a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tles in the catalog
Description
Fixes #19313
Motivation and Context
See #19313 with perfect description by Zack and some nice videos.
How Has This Been Tested?
Manually.
Screenshots (if appropriate):
After the fix we have an item for deleted entity, without a link.
The pagination does not break anymore, has no more holes.
Types of changes
Checklist: