Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature Request) Support ValueFile from Google Cloud Stroage #9172

Open
asubramanianrl opened this issue Nov 13, 2023 · 1 comment · May be fixed by #9182
Open

(Feature Request) Support ValueFile from Google Cloud Stroage #9172

asubramanianrl opened this issue Nov 13, 2023 · 1 comment · May be fixed by #9182
Labels
kind/feature-request

Comments

@asubramanianrl
Copy link

Expected behavior

Skaffold should read the ValueFile from Google Storage Bucket as well(with Application Default Credential)

    patches:
      - op: add
        path: /deploy/helm/releases/0/valuesFiles
        value:
          - env-values/dev-values.yaml
          - external-configuration/env-values/dev-values.yaml
          - gs://XXXX/ops.yaml

Actual behavior

We hold the infrastructure-related information in the Storage Bucket and it must be available publicly to pass it to the Helm. Due to security reasons, we want to block the public usage of this bucket. At the moment, we will have a workaround to download this file using the prehook and pass it with the local path.

    patches:
      - op: add
        path: /deploy/helm/releases/0/valuesFiles
        value:
          - env-values/dev-values.yaml
          - global/env-values/dev-values.yaml
          - https://storage.googleapis.com/XXXX/ops.yaml
@asubramanianrl
Copy link
Author

I would like to take the opportunity to contribute.

What is the best way to copy the files from GCS? I see that Skaffold is using the gsutil cmd to pull the manifests. Can I try the same or use the GCS SDK ?

@ashokhein ashokhein linked a pull request Nov 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow ValuesFile from GCS ashokhein/skaffold
2 participants
@asubramanianrl @ericzzzzzzz