Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NO_DOCKER mode of running all (if possible) commands with pinned deps (e.g. using bingo) #802

Open
bwplotka opened this issue Jan 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bwplotka
Copy link
Collaborator

Currently all commands run things in docker container (including e2e and kind). This has benefit of ultimate hermetization (less "why it works on my machine, but not on CI" moments).

However there are downsides of that: harder to debug those commands (not intuitive, more layers), harder to edit commands (passing arguments), surprising side effects (state is often copied at the start and result is copied back overwriting changes in the mean time, and little to significant (depends on env) latency penalty especially for quick commands.

Since all our tools (at least most) are in Go, we could use https://github.com/bwplotka/bingo to pin them. We could verify envvars, go version, OS etc. We can slim our commands in latency while keeping majority of hermetization benefits. We also can agree on basic prerequisites outside of bingo (e.g. Linux/Mac, modern bash, Go 1.19+ installed etc).

We could also do this work while having NO_DOCKER env OR dedicate copy of the command for no docker run of the same thing to allow playing with the new mode and gather more data what we want 🤗

@bwplotka bwplotka added the enhancement New feature or request label Jan 30, 2024
@pintohutch pintohutch removed their assignment Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants