Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm direct] Handle immutability for spec.metricDescriptor.labels field #1805

Open
3 tasks done
gemmahou opened this issue May 15, 2024 · 1 comment
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@gemmahou
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

Per the API design, it's not allowed to modify any existing spec.metricDescriptor.labels fields, but it's possible to add/delete labels.

Can we handle the blocking of updates on labels fields earlier, either in our webhook or direct controller, to avoid sending HTTP requests to the GCP API? This would reduce the number of requests sent to GCP.

Additional information

No response

Importance

No response

@gemmahou gemmahou added the enhancement New feature or request label May 15, 2024
@acpana
Copy link
Collaborator

acpana commented May 22, 2024

cc @acpana @yuwenma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants