Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mockgcp coverage for sqlInstance settings.edition #1804

Closed
3 tasks done
yuwenma opened this issue May 15, 2024 · 1 comment
Closed
3 tasks done

Add mockgcp coverage for sqlInstance settings.edition #1804

yuwenma opened this issue May 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@yuwenma
Copy link
Collaborator

yuwenma commented May 15, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

We are moving to the direction of using MockGCP to improve the KCC resource test coverage. Related to #1802

Additional information

MockGCP Guide
Mock sql instance

Importance

No response

@yuwenma yuwenma added the enhancement New feature or request label May 15, 2024
@jingyih
Copy link
Collaborator

jingyih commented May 29, 2024

The special behavior of settings.edition field is basically a bug. I don't feel it is worth the time to mimic that behavior in mock. Given that we already added #1823 to cover its behavior against real GCP API, I am going to close this one.

@jingyih jingyih closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants