Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCC support for BigLake tables #1654

Open
3 tasks done
600lyy opened this issue Apr 26, 2024 · 2 comments · May be fixed by #1733
Open
3 tasks done

KCC support for BigLake tables #1654

600lyy opened this issue Apr 26, 2024 · 2 comments · May be fixed by #1733
Labels
enhancement New feature or request

Comments

@600lyy
Copy link
Member

600lyy commented Apr 26, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

As a DB Admin, I want be able to deploy and manage my BigLake resources using KCC

This resource is already available in KCC's terraform subtree , therefore there is no need to update terraform in KCC

Additional information

Terraform examples:
https://cloud.google.com/bigquery/docs/create-cloud-storage-table-biglake#terraform

Importance

No response
@600lyy 600lyy added the enhancement New feature or request label Apr 26, 2024
@600lyy
Copy link
Member Author

600lyy commented May 6, 2024 •
edited

I can confirm that using the current BigQueryTable resource I can create a BigLake table following this example:

https://cloud.google.com/bigquery/docs/create-cloud-storage-table-biglake#terraform

However, I'm not able to set the option

requirePartitionFilter

This property is only under hivePartitioningOptions and timePartitioning

I see that require_partition_filter was added in TF5.2 as a top level property

This PR is to add requirePartitionFilter as a top level property in KCC bigquery resource

@600lyy 600lyy linked a pull request May 8, 2024 that will close this issue
Open
2 tasks
@600lyy
Copy link
Member Author

600lyy commented May 8, 2024

PR submitted: #1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bigquery table require_partition_filter.patch 600lyy/k8s-config-connector
1 participant
@600lyy