Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks customization should expose namespaceSelector #1693

Open
3 tasks done
wrdls opened this issue May 6, 2024 · 1 comment
Open
3 tasks done

webhooks customization should expose namespaceSelector #1693

wrdls opened this issue May 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@wrdls
Copy link

wrdls commented May 6, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

We want to fully exclude system namespace like kube-system as well as other critical namespaces like istio-system from certain webhooks to ensure cluster stability.

See the GKE docs on this: https://cloud.google.com/kubernetes-engine/docs/how-to/optimize-webhooks#unsafe-webhooks

Additional information

Example of how this feature could look like

apiVersion: customize.core.cnrm.cloud.google.com/v1beta1
kind: ValidatingWebhookConfigurationCustomization
metadata:
  name: validating-webhook
spec:
  webhooks:
    - name: deny-immutable-field-updates
      namespaceSelector:
        matchExpressions:
          - key: kubernetes.io/metadata.name
            operator: NotIn
            values:
              - kube-system
              - kube-node-lease

Importance

This is highly important for us to consider Config Connector as a serious option to run in our production environments.

@wrdls wrdls added the enhancement New feature or request label May 6, 2024
@cheftako
Copy link
Collaborator

@nicslatts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants