Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for our first Direct-Actuation resource #1681

Open
3 of 14 tasks
justinsb opened this issue May 2, 2024 · 0 comments
Open
3 of 14 tasks

Checklist for our first Direct-Actuation resource #1681

justinsb opened this issue May 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@justinsb
Copy link
Collaborator

justinsb commented May 2, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

Let's create a checklist for our first direct-actuation resource (LoggingLogMetric)

  • Review directbase_controller for todos
  • Verify pause support
  • Verify abandon-on-delete support
  • Decide behaviour for state-into-spec: merge (do we drop fields?)
  • Create tests for any "difficult" scenarios
  • Create tests
  • Audit mapping logic - e.g. fields should have a if foo != nil check
  • Verify immutability webhook works
  • Verify references to LoggingLogMetric
  • Verify references from LoggingLogMetric
  • Verify IAM

cc @yuwenma , cc @cheftako (I think you can both edit this issue to add things to the checklist!)

We could also break this out into bugs, I guess, but that might be overkill!

Additional information

No response

Importance

No response

@justinsb justinsb added the enhancement New feature or request label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant