Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture VCR & golden output from our periodic ("real") tests #1656

Open
3 tasks done
justinsb opened this issue Apr 26, 2024 · 2 comments
Open
3 tasks done

Capture VCR & golden output from our periodic ("real") tests #1656

justinsb opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@justinsb
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

We run tests against real GCP periodically (i.e. not on every PR). If we could capture the output from that, we might be able to avoid having to run hack/record-gcp against resources. It's not a big deal for simple resources, but as we start to mock more complicated APIs it's not always trivial to run the tests locally - they might require access to specific orgs/projects/folders etc.

We can start with needing a googler to copy the data, at least until we're sure that there are no secrets/tokens here (there shouldn't be, but I don't think we want to block on proving that)

Additional information

No response

Importance

No response

@justinsb justinsb added the enhancement New feature or request label Apr 26, 2024
@justinsb
Copy link
Collaborator Author

cc @gemmahou do you want to work on this one?

@gemmahou gemmahou self-assigned this Apr 26, 2024
@gemmahou
Copy link
Collaborator

Yeah, assigned to myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants