Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: logginglogmetric: clarify unset for direct controller #1641

Open
acpana opened this issue Apr 24, 2024 · 0 comments
Open

enh: logginglogmetric: clarify unset for direct controller #1641

acpana opened this issue Apr 24, 2024 · 0 comments
Assignees

Comments

@acpana
Copy link
Collaborator

acpana commented Apr 24, 2024

We need to consider the unset intent for logginglogmetric as a direct controller.

That way a field that isn't specified is unmanaged (instead of forcing the value to empty).  It's a decision though, and we probably should reach an agreement.  I think that for the current Terraform controllers, we consider nil fields to be unset.

I do think it also makes it harder to clear a field though.

Originally posted by @justinsb in #1499 (comment)

@acpana acpana self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant