Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: run dynamic tests against kind broken? #1584

Open
acpana opened this issue Apr 17, 2024 · 0 comments
Open

tests: run dynamic tests against kind broken? #1584

acpana opened this issue Apr 17, 2024 · 0 comments

Comments

@acpana
Copy link
Collaborator

acpana commented Apr 17, 2024

Circling back on our dynamic testing run-tests flag. The docs currently state that:

Set [test-target] to the kind (in all lower-case letters) in the following command to run all the tests for your resource.

https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/59a3462509b854bbb98ae0bfa47d9044cf1b4d3c/README.NewResourceFromTerraform.md#run-tests

But @ziyue-101's experience and mine is that kind may not be written into the basic test names (the leaf directories) that the regex is matched against. More on this structure as an edge case is elaborated on this PR: #1424

We can update our README and/or use some of the ideas in the PR to make matching against kind work in those edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant