Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move away from LDFlags embedding for version and git sha, use go embed instead #144

Open
2 tasks
hessjcg opened this issue Dec 12, 2022 · 0 comments
Open
2 tasks

chore: Move away from LDFlags embedding for version and git sha, use go embed instead #144

hessjcg opened this issue Dec 12, 2022 · 0 comments
Assignees
@hessjcg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Dec 12, 2022

Currently we use LDFLAGS to embed the contents of version.txt and the head SHA from our git repo into the built artifact.
Instead we want to use go embed. Investigate how to do this, and make sure it works properly.

  • Embed the version from version.txt
  • Embed the git sha
@hessjcg hessjcg added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 12, 2022
@hessjcg hessjcg mentioned this issue Dec 12, 2022
Merged
@hessjcg hessjcg added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttosta-google @hessjcg