Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RingBuffer #347

Open
hoch opened this issue Oct 13, 2023 · 3 comments
Open

Improve RingBuffer #347

hoch opened this issue Oct 13, 2023 · 3 comments
Assignees

Comments

@hoch
Copy link
Member

hoch commented Oct 13, 2023

A comment from @mjwilson-google:

The way we're reading or writing the samples is also kinda strange; we could probably just be updating the index directly instead of making a new temporary every iteration. But that at least looks like it's correct, just inefficient. If we updated the index directly each iteration we wouldn't need to do the correction after the loop at all.

I say we should prioritize improving our AudioWorklet examples because it is often used/referred by developers.

@mjwilson-google
Copy link
Collaborator

This was referencing https://github.com/GoogleChromeLabs/web-audio-samples/blob/main/src/audio-worklet/design-pattern/lib/wasm-audio-helper.js but it seems like we have some other ring buffer implementations as well that might be worth looking at too.

@Daksh-10
Copy link
Contributor

@hoch @mjwilson-google I worked on this issue and created a pull request #352

@hoch hoch reopened this Mar 8, 2024
@hoch
Copy link
Member Author

hoch commented Mar 8, 2024

This is a tracking issue for improving the RingBuffer. The PR above can be considered one task that we completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants