Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Data triangulation: Network, Application, PSAT #628

Open
maitreyie-chavan opened this issue Apr 16, 2024 · 1 comment
Open

CLI Data triangulation: Network, Application, PSAT #628

maitreyie-chavan opened this issue Apr 16, 2024 · 1 comment
Assignees
Milestone

Comments

@maitreyie-chavan
Copy link
Collaborator

Description:

To ensure consistency between extension and CLI results for all cookies across frames, we must gather and monitor data from the Network and other panels to accurately associate cookies with their respective frames. This process will eliminate the need for the 'unmapped frames' section in the CLI report

@ayushnirwal
Copy link
Collaborator

'Unknown Frames' come from Page.getCookies query resulting in cookie data without any frame-related data. Therefore we had to attribute those cookies to 'Unknown Frames'. The usage of Page.getCookies was necessary to add data about the cookies that were missed in Network events.
This was solved in PR #704 by relying on CDP and using Target.setAutoAttach to flatten the target tree. This eliminates the problem of missing network events when network events of the main frame are listened to.
There is no need to scrape data from the network and application panel and triangulate them to get correct cookie data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under Review
Development

No branches or pull requests

3 participants