Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Only works in Chrome #19

Open
zouhir opened this issue Jul 1, 2018 · 5 comments
Open

Bug: Only works in Chrome #19

zouhir opened this issue Jul 1, 2018 · 5 comments

Comments

@zouhir
Copy link

zouhir commented Jul 1, 2018

Feed does not load on other browsers then Chrome, tried both Edge & FF — app shell loads but feed keeps loading.

Any plans to make it cross browser?
Thank you.

@ebidel
Copy link
Contributor

ebidel commented Jul 2, 2018

Yea, apologies for this. It works in Safari and Chrome, but not FF and Edge. FF is tricky b/c they now support ES modules but not dynamic import(). So the feature detect has gotten harder.

Edge should hit the rollup'd nomodule fallback script. What errors do you see from it?

@PicoCreator
Copy link

PicoCreator commented Jul 30, 2018

Unfortunately it does not work on Edge. Test GIF below.

devweb-firehose-edge

With the following exception from the dev tools

devweb-firehose-exception

Which traces to

devweb-firehose-stacktrace


The full uilicious test case used for the GIF is as followed

// Lets load year 2017, as we can predict 
// the expected load result
I.goTo("https://devwebfeed.appspot.com/?year=2017");

// Validate the header loads
I.see("dev-web firehose");
I.see("Older");

// With the Dec 28, 2017 result
I.see("What's New In DevTools (Chrome 63)");

So... on the plus side, with the same test script, I can confirm its working on safari.

devweb-firehose-safari

@ebidel
Copy link
Contributor

ebidel commented Jul 30, 2018

So it appears Edge doesn't support URLSearchParams on URL. This page suggests it does. This page suggests it doesn't. :\

@zouhir
Copy link
Author

zouhir commented Jul 30, 2018

Hi Ebidel,

apologies for my delayed responses & inability to follow up & debug the issue yet.

URLSearchParams is supported, the 2nd link has to be updated, the first link seems accurate.

capture

I will try to look at this soon or alternatively open and edge bug so someone on the team can look an help us here.

Many thanks!

@PicoCreator
Copy link

Took a deeper dive into this, URLSearchParam was just rolled out in Edge 17; While it is not supported in Edge 16. So in that expect the documentation is correct (it does say 17 onwards).

The following are screenshots from crossbrowsertesting of IE16

screen shot 2018-07-31 at 6 42 23 pm

Fo IE17, while URLSearchParams is supported, I get a pretty much untracable "SCRIPT5022: Syntax Error" pointing to line 1,1 of the html file

screen shot 2018-07-31 at 6 49 20 pm

screen shot 2018-07-31 at 6 42 53 pm

Sorry for the confusion : didn't occur to me that I would need to update my windows (so it does something haha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants