-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] comlink needs to be an external for server bundle #19
Comments
I haven't had a chance to dig into it yet, but my guess is that this happens due to your bundler ending up choosing the browser version of Comlink rather than the Node version. This is a tricky subject, since bundlers are often configured to prefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was playing around with
comlink-loader
with an isomorphic react app. I usedmulti
andinline
options.For the client bundle, everything works fine, but it failed when bundling the server bundle.
export 'expose' was not found in 'comlink'
After some digging, I found out that it is fixed after I add
/^comlink/
to webpackexternals
. (My webpackexternals
config is a bit different, I do not usewebpack-node-externals
)So, is it expected that comlink only work when externalised? It didn't throw any error on v1 though.
The text was updated successfully, but these errors were encountered: