New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new UIString for non-composited-animations due to custom properties #14521
Labels
Comments
Hi @brendankenny I have gone through the issue and I can work on it. Can you assign this to me? |
i would like to contribute to this issue. |
@adamraine Can you please assign this issue to me? |
@brendankenny can you please assign this to me ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Animating custom properties appear to always end up non-composited (at least outside of CSS painting), and get lumped with all the other non-composited CSS properties found in the trace (don't be surprised like me and note that this happens regardless of what the property is animating, e.g. animating
translate
through fixed values is usually composited, animating--yheight
intranslate: 0 var(--yheight)
will not be).For example, you could end up with
Unsupported CSS Property: --swing-y
innon-composited-animations
alongside other failed animations givingUnsupported CSS Property: color
(or even in a list from the same animation,Unsupported CSS Properties: --swing-y, color
.It would be nice to separate the custom properties and give a little more context. You can probably figure out what it's referring to pretty easily, but it is a little weird to have these two types of things put together.
One solution we've discussed was splitting out any unsupported properties (probably here) beginning with
--
and then giving a new failure string for them, e.g.Custom CSS properties cannot be animated on the compositor: --swing-y
These custom properties are Chromium-based browsers only right now, so low priority for this fix.
The text was updated successfully, but these errors were encountered: