Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple videos can be played at the same time when they're being played in PiP mode #178

Open
felipebochehin87 opened this issue Jan 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@felipebochehin87
Copy link

Bug Description

Multiple videos can be played at the same time when they're being played in PiP mode.

Expected Behaviour

When a new video is played in PiP, I kindly suggest stopping the existing one so that we only have the latest video playing.

Steps to reproduce

  1. Go to https://kinoweb-dev--staging-2ra3ji0i.web.app/
  2. Click on any video
  3. Click on Play
  4. Click on the PiP button
  5. Click on Kino logo at the upper left corner of the screen
  6. Click on another video
  7. Click on Play
  8. Click on the PiP button - see and hear that both videos are active and you cannot stop the first one, even if you close the second video, the PiP will close, but the first video will still be playing (you won't see it, but you can hear it)

Screenshots

PIP.mutiple.videos.at.the.same.time.mp4

Additional context

  • Project version:
  • Node version:
  • OS:
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone12]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@felipebochehin87 felipebochehin87 added the bug Something isn't working label Jan 21, 2022
@felipebochehin87
Copy link
Author

LGTM. PiP displays one video at a time, and if a second video start on PiP, the first one stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant