Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a pull request template to the repository as like issue template #1113

Open
Gmin2 opened this issue Feb 27, 2024 · 2 comments · May be fixed by #1123
Open

Adding a pull request template to the repository as like issue template #1113

Gmin2 opened this issue Feb 27, 2024 · 2 comments · May be fixed by #1123
Assignees
@Gmin2

Comments

@Gmin2
Copy link

Gmin2 commented Feb 27, 2024

Describe the bug

Currently, our repository lacks a pull request (PR) template, which can provide helpful guidance and ensure consistency when contributors submit PRs. To improve our PR process, we should add a PR template to the repository.

Expected behavior
When creating pull request contributors will be ask to specify what issues it solves(issue number) and if they have run the lint while making the changes

Notes
Would like to work on it
@Gmin2
Copy link
Author

Gmin2 commented Feb 28, 2024

Hey @oliverdunk should i proceed with making the PR for this

@oliverdunk
Copy link
Member

Hi @utnim2! I don't think we need too much here, but open to a very basic template. I would leave out running lint (since we have CI to check this) but including a few other things like testing notes and related content might be helpful.

@Gmin2 Gmin2 linked a pull request Mar 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gmin2 Gmin2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: added a pull request template to the repository Gmin2/chrome-extensions-samples
2 participants
@oliverdunk @Gmin2