Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

UI reload crash when using multiple tabs #630

Open
clragon opened this issue Nov 10, 2019 · 6 comments
Open

UI reload crash when using multiple tabs #630

clragon opened this issue Nov 10, 2019 · 6 comments
Labels
bug Confirmed bugs.

Comments

@clragon
Copy link

clragon commented Nov 10, 2019

Technical information

Using version:

  • master (running from GitHub-published source code, currently v3.0.0-pre)

Running on:

  • Windows

How comfortable you are with your system and/or IT in general:

  • My machine is fully under my control, tell me what you need

Problem

Reloading the app and opening a previously open terminal tab leads to a crash.

12774246

@GitSquared
Copy link
Owner

Tabs state isn't saved between window reloads, which causes this.
Perhaps the main process could forward a list of open sockets via IPC?
Will look into this

@GitSquared GitSquared changed the title Tab reload crash UI reload crash when using multiple tabs Nov 14, 2019
@GitSquared GitSquared added the bug Confirmed bugs. label Nov 14, 2019
@Animus-Surge
Copy link
Contributor

Might have already fixed this in #892

@GitSquared
Copy link
Owner

Indeed, it doesn't crash anymore... The state is still not saved between UI reloads though, so I think we can keep this open.

Unlikely to ever be fixed before a rewrite, to be honest.

@Animus-Surge
Copy link
Contributor

The state is still not saved between UI reloads

Can look into that if you want. Doesn’t seem like it should be too hard (famous last words)

@GitSquared
Copy link
Owner

haha, sure, feel free to try it.

@GitSquared GitSquared removed the bug label Dec 13, 2020
@ghost

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants