Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Folder names ending with file extension treated as files #1167

Open
4 of 9 tasks
a2br opened this issue Aug 17, 2021 · 1 comment
Open
4 of 9 tasks

Folder names ending with file extension treated as files #1167

a2br opened this issue Aug 17, 2021 · 1 comment
Labels
bug Confirmed bugs.

Comments

@a2br
Copy link

a2br commented Aug 17, 2021

Technical information

Using version:

  • master (running from GitHub-published source code, currently v2.2.8-pre)
  • latest (latest release, currently v2.2.7)

Running on:

  • Linux
  • Windows
  • macOS

How comfortable you are with your system and/or IT in general:

  • I'm kind of lost, honestly
  • I know what's up, I could help you run some commands or checks
  • My machine is fully under my control, tell me what you need
  • I attended Defcon last year

Problem

Folders ending with .js have JS file icon instead of folder icon. See below.
Screen Shot 2021-08-17 at 21 35 10

@a2br a2br added the investigation Base triage label for bug reports. label Aug 17, 2021
@GitSquared GitSquared added bug Confirmed bugs. and removed investigation Base triage label for bug reports. labels Aug 21, 2021
@GitSquared
Copy link
Owner

Thanks for the report!

Looks like we would need to change this logic:

default:
let iconName = this.fileIconsMatcher(e.name);
icon = this.icons[iconName];
if (typeof icon === "undefined") {
if (e.type === "file") icon = this.icons.file;
if (e.type === "dir") {
icon = this.icons.dir;
type = "folder";
}
if (typeof icon === "undefined") icon = this.icons.other;
} else if (e.category !== "dir") {
type = iconName.replace("icon-", "");
} else {
type = "special folder";
}
break;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bugs.
Projects
None yet
Development

No branches or pull requests

2 participants