Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burning Hands - optional but cool #19

Open
TotoR115 opened this issue Dec 21, 2023 · 1 comment
Open

Burning Hands - optional but cool #19

TotoR115 opened this issue Dec 21, 2023 · 1 comment

Comments

@TotoR115
Copy link

TotoR115 commented Dec 21, 2023

2 issues:

  • The modifications done to the spell make it unusable; the range in the spell ability tab is too big (5) in comparison to the size of the visual animation, the spell never hit.
  • In addition, the animation is not like the original.
@TotoR115
Copy link
Author

TotoR115 commented Jan 5, 2024

I have checked further:

The modifications done to the spell make it unusable; the range in the spell ability tab is too big (5), the spell never hit. It should be 2 (as vanilla) or max 3.

from lib core_spell_bulk.tph:

spwi103, null, null, null, null, null, null, 5, null, null, null, null => spwi103 // Burning Hands (WIZARD_BURNING_HANDS)

As the vanilla spell is mod by fixpack to 5, the new projectil should be bigger
WRITE_SHORT 0x206 64 // range (5')

Could be between 70 and 75, 64 is too small;
for the record, the vanilla projectile is not long enough and the spell does not always touch the target at range = 5...

In addition, the animation is not like the original.

there is a typo in setup-bg2fixpack.tp2 as 0 is Fireball - 0:

WRITE_BYTE 0x217 0 // no explosion

should be WRITE_BYTE 0x217 255 // no explosion

Lastly a shell spell should be created to include the original spell and keep the original projectile:

// make burning hands AoE instead of single target
COPY_EXISTING ~cspray.pro~   ~override/burnhand.pro~
  WRITE_SHORT 0x206 75  // range (5')
  WRITE_BYTE  0x217  255 // no explosion

ADD_PROJECTILE ~override/burnhand.pro~

COPY_EXISTING ~spwi103.spl~  ~override/spwi103a.spl~
  READ_ASCII 0x08 "spwi103_name"
  WRITE_LONG 0x08 ~-1~
  LPF ALTER_SPELL_HEADER INT_VAR target = 4 projectile = burnhand END // use new projectile, target any point

COPY ~bg2fixpack/spl/spwi103.spl~  ~override~
  WRITE_ASCIIE 0x08 ~%spwi103_name%~
  LPF ALTER_SPELL_HEADER INT_VAR target = 4 range = 4 projectile = 22 END // use Burning Hand Projectile, target any point, range = 4 because the graphics of the vanilla projectile is not long enough, the spell does not always touch the target at 5...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant