Exports/Imports table in win32 shell ext page showing blank rows #413

ksharperd · 2024-04-10T12:23:45Z

Issue

Exports/Imports table in win32 shell ext page showing blank rows, but Copy/Export works fine.

OS Version

Windows 10 Build 19045.4291

Details

I'm using locally built version(with commit fcfeea7) without any change.
configured with cmake . -G "Visual Studio 14 2015" -A "x64" -DCMAKE_SYSTEM_VERSION="8.1" -DCMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION="8.1" and build with 'Release' config since there is a build error when i try to build with WinSDK 10 or newer Visual Studio version.

**this issue has occurred two or three weeks ago though.

The text was updated successfully, but these errors were encountered:

GerbilSoft · 2024-04-13T23:59:03Z

I've seen the ListView issue happen occasionally but I thought I had that fixed...

Can you post the build errors you're encountering with later versions of Visual Studio and/or the Windows 10 SDK? I've been using MSVC 2022 for release builds (v143 for most architectures; v141_xp for i386) without any issues.

GerbilSoft · 2024-04-14T00:14:27Z

I've managed to reproduce this error in the debug build, and it isn't the same issue I was seeing before. The issue I was seeing before was on all ListViews. This one seems to just be for the import/export tables.

GerbilSoft · 2024-04-14T00:31:20Z

Commit 59c3d23 should fix this.

GerbilSoft · 2024-04-16T03:02:05Z

Reopening because I'd still like to know what was causing build issues with later versions of MSVC, since I can't reproduce it here.

ksharperd · 2024-04-16T04:21:09Z

Reopening because I'd still like to know what was causing build issues with later versions of MSVC, since I can't reproduce it here.

@GerbilSoft sorry for my late replay :(
to repro, i config with cmake .. -G "Visual Studio 17 2022" -A "x64" and build with cmake --build ./ --config Release

this is my binlog obtained from msbuild: https://litter.catbox.moe/rtz3ug.binlog

**u can use https://msbuildlog.com/ to open *.binlog

@ksharperd

…f Windows headers have already been included. I can't reproduce this issue locally, but I received a report about this from a user who was using the Windows 11 SDK (10.0.22621.0) with MSVC 2022. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft · 2024-04-16T04:41:29Z

Looks like it was a conflict between the EXE parser's custom headers and the Windows SDK headers, though I'm not sure why it didn't show up on my system, even with the same MSVC and SDK version...

Try building the latest commit with MSVC 2022 and SDK 10.0.22621.0 and let me know if you encounter any more errors.

ksharperd · 2024-04-16T04:52:25Z

latest commit seems solve redefinition error, but build still encountered some errors: https://litter.catbox.moe/qc1yic.binlog

@ksharperd

…d in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft · 2024-04-16T04:57:19Z

It seems IMAGE_IMPORT_DIRECTORY is not defined in the Windows SDK. Reworked that so it's unconditionally defined by exe_pe_structs.h.

@ksharperd

…lso not present in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft · 2024-04-16T04:59:35Z

...and the IMAGE_DATA_DIRECTORY_* constants.

@ksharperd

…ined in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft · 2024-04-16T05:02:28Z

I believe that should be all of it now. Try building again.

ksharperd · 2024-04-16T05:51:37Z

still catch some build errors, i can successfully build with my addition changes: https://litter.catbox.moe/g688xp.patch

GerbilSoft · 2024-04-21T15:57:43Z

Pushed some more changes that should hopefully fix everything that was in that patch.

ksharperd · 2024-04-29T12:14:23Z

thanks for investigate! but i still got these errors while building latest commit

rom-properties\src\libromdata\disc\PEResourceReader.cpp(784,31): error C2664: 'LibRpFile::IRpFilePtr LibRomData::PEResourceReader::open(uint16_t,int,int)': cannot conver
t argument 1 from 'LPWSTR' to 'uint16_t'
rom-properties\src\libromdata\disc\NEResourceReader.cpp(699,31): error C2664: 'LibRpFile::IRpFilePtr LibRomData::NEResourceReader::open(uint16_t,int,int)': cannot conver
t argument 1 from 'LPWSTR' to 'uint16_t'

should we add a overload for it?

GerbilSoft · 2024-05-19T17:09:04Z

Should be working now. Please re-test and let me know if there are any other issues.

ksharperd · 2024-05-23T14:56:57Z

Should be working now. Please re-test and let me know if there are any other issues.

unfortunately not :(
latest binlog: https://files.catbox.moe/u18mlq.binlog

GerbilSoft · 2024-05-27T14:11:15Z

Added another attempt at a workaround in commit ed2999e. Please try that out and let me know how it goes.

ksharperd · 2024-06-02T12:57:01Z

Added another attempt at a workaround in commit ed2999e. Please try that out and let me know how it goes.

I can confirm that this commit fixes the build issue, but try to open shell ext page will crash the explorer with 0xc0000005.

*Edit: romdata-5.dll cause the crash, i will attach this file alongside with other components since i'm not comfortable with Windows debugging : )
binaries: https://files.catbox.moe/i77kne.7z
crash dump: https://files.catbox.moe/7s78ye.dmp

GerbilSoft · 2024-06-02T15:25:13Z

From WinDbg:

0:021> k
 # Child-SP          RetAddr           Call Site
00 00000000`1037d278 00007ffe`a3d8bea0 ntdll!NtWaitForMultipleObjects+0x14
01 00000000`1037d280 00007ffe`a3d8bd9e KERNELBASE!WaitForMultipleObjectsEx+0xf0
02 00000000`1037d570 00007ffe`a4a5f93a KERNELBASE!WaitForMultipleObjects+0xe
03 00000000`1037d5b0 00007ffe`a4a5f376 kernel32!WerpReportFaultInternal+0x58a
04 00000000`1037d6d0 00007ffe`a3e5da19 kernel32!WerpReportFault+0xbe
05 00000000`1037d710 00007ffe`a67822c9 KERNELBASE!UnhandledExceptionFilter+0x3d9
06 00000000`1037d830 00007ffe`a6782d82 ntdll!TppExceptionFilter+0x75
07 00000000`1037d870 00007ffe`a67156ce ntdll!TppWorkerpInnerExceptionFilter+0x1a
08 00000000`1037d8a0 00007ffe`a66fca06 ntdll!TppWorkerThread$filt$5+0x19
09 00000000`1037d8e0 00007ffe`a670cc9e ntdll!_C_specific_handler+0x96
0a 00000000`1037d950 00007ffe`a671247f ntdll!_GSHandlerCheck_SEH+0x6a
0b 00000000`1037d980 00007ffe`a66c14b4 ntdll!RtlpExecuteHandlerForException+0xf
0c 00000000`1037d9b0 00007ffe`a6710f8e ntdll!RtlDispatchException+0x244
0d 00000000`1037e0c0 00007ffe`7345ba98 ntdll!KiUserExceptionDispatch+0x2e
*** WARNING: Unable to verify timestamp for romdata-5.dll
0e 00000000`1037e7c0 00000000`00000030 romdata_5!LibRpFile::RpFilePrivate::reOpenFile+0x3e8
0f 00000000`1037e7c8 00000000`00000000 0x30

From Visual Studio 2022:

>	romdata-5.dll!LibRpFile::RpFilePrivate::reOpenFile(void)	C++
 	romdata-5.dll!LibRpFile::RpFile::init(void)	C++
 	romdata-5.dll!LibRpFile::RpFile::RpFile(wchar_t const *,enum LibRpFile::RpFile::FileMode)	C++
 	romdata-5.dll!std::make_shared<class LibRomData::XboxDisc,class std::shared_ptr<class LibRpFile::IRpFile> const &>(class std::shared_ptr<class LibRpFile::IRpFile> const &)	C++
 	romdata-5.dll!LibRomData::RomDataFactory::create(wchar_t const *,unsigned int)	C++
 	rom-properties.dll!RP_ShellPropSheetExt::Initialize(struct _ITEMIDLIST const *,struct IDataObject *,struct HKEY__ *)	C++

Visual Studio doesn't seem to want to map the dump file and PDBs to the original source code, which is making this difficult to debug. I'll try to reproduce it with a local build.

EDIT: I can't seem to reproduce this locally... In Visual Studio, can you use "Attach to Process", attach to explorer.exe, then try to reproduce the crash and take a screenshot of where Visual Studio shows the exception?

ksharperd · 2024-06-02T18:26:09Z

From WinDbg:

0:021> k
 # Child-SP          RetAddr           Call Site
00 00000000`1037d278 00007ffe`a3d8bea0 ntdll!NtWaitForMultipleObjects+0x14
01 00000000`1037d280 00007ffe`a3d8bd9e KERNELBASE!WaitForMultipleObjectsEx+0xf0
02 00000000`1037d570 00007ffe`a4a5f93a KERNELBASE!WaitForMultipleObjects+0xe
03 00000000`1037d5b0 00007ffe`a4a5f376 kernel32!WerpReportFaultInternal+0x58a
04 00000000`1037d6d0 00007ffe`a3e5da19 kernel32!WerpReportFault+0xbe
05 00000000`1037d710 00007ffe`a67822c9 KERNELBASE!UnhandledExceptionFilter+0x3d9
06 00000000`1037d830 00007ffe`a6782d82 ntdll!TppExceptionFilter+0x75
07 00000000`1037d870 00007ffe`a67156ce ntdll!TppWorkerpInnerExceptionFilter+0x1a
08 00000000`1037d8a0 00007ffe`a66fca06 ntdll!TppWorkerThread$filt$5+0x19
09 00000000`1037d8e0 00007ffe`a670cc9e ntdll!_C_specific_handler+0x96
0a 00000000`1037d950 00007ffe`a671247f ntdll!_GSHandlerCheck_SEH+0x6a
0b 00000000`1037d980 00007ffe`a66c14b4 ntdll!RtlpExecuteHandlerForException+0xf
0c 00000000`1037d9b0 00007ffe`a6710f8e ntdll!RtlDispatchException+0x244
0d 00000000`1037e0c0 00007ffe`7345ba98 ntdll!KiUserExceptionDispatch+0x2e
*** WARNING: Unable to verify timestamp for romdata-5.dll
0e 00000000`1037e7c0 00000000`00000030 romdata_5!LibRpFile::RpFilePrivate::reOpenFile+0x3e8
0f 00000000`1037e7c8 00000000`00000000 0x30

From Visual Studio 2022:

>	romdata-5.dll!LibRpFile::RpFilePrivate::reOpenFile(void)	C++
 	romdata-5.dll!LibRpFile::RpFile::init(void)	C++
 	romdata-5.dll!LibRpFile::RpFile::RpFile(wchar_t const *,enum LibRpFile::RpFile::FileMode)	C++
 	romdata-5.dll!std::make_shared<class LibRomData::XboxDisc,class std::shared_ptr<class LibRpFile::IRpFile> const &>(class std::shared_ptr<class LibRpFile::IRpFile> const &)	C++
 	romdata-5.dll!LibRomData::RomDataFactory::create(wchar_t const *,unsigned int)	C++
 	rom-properties.dll!RP_ShellPropSheetExt::Initialize(struct _ITEMIDLIST const *,struct IDataObject *,struct HKEY__ *)	C++

Visual Studio doesn't seem to want to map the dump file and PDBs to the original source code, which is making this difficult to debug. I'll try to reproduce it with a local build.

EDIT: I can't seem to reproduce this locally... In Visual Studio, can you use "Attach to Process", attach to explorer.exe, then try to reproduce the crash and take a screenshot of where Visual Studio shows the exception?

yes i can see the cause:

RpFile_scsi_win32.cpp:67
d->filename was nullptr

btw, hitting exception seems make everything freeze except cursor(even Visual Studio itself is unclickable), but i can still catch the error fortunately 😂

@ksharperd

…enameW, not d->filename. d->filename is usually nullptr at this point on Windows. Also, ensure that d->filenameW is neither NULL nor an empty string. It shouldn't happen, but a redundant check is better than a crash. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft · 2024-06-02T19:15:29Z

Looks like the problem is RpFile_scsi_win32 wasn't updated to use d->filenameW. I'm not sure why I wasn't hitting this issue locally...

Updated it to use d->filenameW, plus a NULL pointer check.

ksharperd · 2024-06-03T09:34:35Z

Looks like the problem is RpFile_scsi_win32 wasn't updated to use d->filenameW. I'm not sure why I wasn't hitting this issue locally...

Updated it to use d->filenameW, plus a NULL pointer check.

yeah, it fix the crash but rom properties tab just disappear.

i guess we need more work to make newer win-sdk version work, a long journey... isn't it? 🤷‍♂️

GerbilSoft self-assigned this Apr 14, 2024

GerbilSoft added the bug label Apr 14, 2024

GerbilSoft added this to the 2.4 milestone Apr 14, 2024

GerbilSoft closed this as completed in 59c3d23 Apr 14, 2024

GerbilSoft reopened this Apr 16, 2024

GerbilSoft added a commit that referenced this issue Apr 16, 2024

[libromdata] exe_pe_structs.h: IMAGE_IMPORT_DIRECTORY is *not* define…

f373055

…d in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft added a commit that referenced this issue Apr 16, 2024

[libromdata] exe_pe_structs.h: IMAGE_DATA_DIRECTORY_* constants are a…

e8e99e2

…lso not present in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

GerbilSoft added a commit that referenced this issue Apr 16, 2024

[libromdata] exe_pe_structs.h: IMAGE_FILE_MACHINE_POWERPCBE isn't def…

dff1b57

…ined in the Windows SDK. See #413: Exports/Imports table in win32 shell ext page showing blank rows Reported by @ksharperd.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exports/Imports table in win32 shell ext page showing blank rows #413

Exports/Imports table in win32 shell ext page showing blank rows #413

ksharperd commented Apr 10, 2024

GerbilSoft commented Apr 13, 2024 •

edited

Loading

GerbilSoft commented Apr 14, 2024

GerbilSoft commented Apr 14, 2024

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024 •

edited

Loading

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024

GerbilSoft commented Apr 21, 2024

ksharperd commented Apr 29, 2024

GerbilSoft commented May 19, 2024

ksharperd commented May 23, 2024

GerbilSoft commented May 27, 2024

ksharperd commented Jun 2, 2024 •

edited

Loading

GerbilSoft commented Jun 2, 2024 •

edited

Loading

ksharperd commented Jun 2, 2024 •

edited

Loading

GerbilSoft commented Jun 2, 2024

ksharperd commented Jun 3, 2024

Exports/Imports table in win32 shell ext page showing blank rows #413

Exports/Imports table in win32 shell ext page showing blank rows #413

Comments

ksharperd commented Apr 10, 2024

Issue

OS Version

Details

GerbilSoft commented Apr 13, 2024 • edited Loading

GerbilSoft commented Apr 14, 2024

GerbilSoft commented Apr 14, 2024

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024 • edited Loading

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

GerbilSoft commented Apr 16, 2024

ksharperd commented Apr 16, 2024

GerbilSoft commented Apr 21, 2024

ksharperd commented Apr 29, 2024

GerbilSoft commented May 19, 2024

ksharperd commented May 23, 2024

GerbilSoft commented May 27, 2024

ksharperd commented Jun 2, 2024 • edited Loading

GerbilSoft commented Jun 2, 2024 • edited Loading

ksharperd commented Jun 2, 2024 • edited Loading

GerbilSoft commented Jun 2, 2024

ksharperd commented Jun 3, 2024

GerbilSoft commented Apr 13, 2024 •

edited

Loading

ksharperd commented Apr 16, 2024 •

edited

Loading

ksharperd commented Jun 2, 2024 •

edited

Loading

GerbilSoft commented Jun 2, 2024 •

edited

Loading

ksharperd commented Jun 2, 2024 •

edited

Loading