Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: New Filter dialog is small #871

Open
RocketRide9 opened this issue Mar 23, 2024 · 3 comments
Open

[Bug]: New Filter dialog is small #871

RocketRide9 opened this issue Mar 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@RocketRide9
Copy link

Describe the bug

New Filter default size is too small. It's default size could be made bigger.

Steps To Reproduce

  1. Go to Settings
  2. Filters
  3. Add Filter...
  4. See dialog window

Logs and/or Screenshots

изображение

IMO dialog should be bigger to fit it's content without scrolling

Instance Backend

Mastodon

Operating System

Linux

Package

Flatpak

Troubleshooting information

No response

Additional Context

No response

@RocketRide9 RocketRide9 added the bug Something isn't working label Mar 23, 2024
@GeopJr
Copy link
Owner

GeopJr commented Mar 23, 2024

Thanks for the suggestion!

One thing I'd like to preserve is the 'depth' of the dialogs. I want the "Filter edit" dialog to still seem as if it's a dialog of the "Preferences" dialog. Higher values while they look ok when the window in also big, they start losing their 'depth' as the window shrinks:

Screencast.from.2024-03-24.01-48-57.webm

Maybe I'm overthinking it and 'depth' isn't that important? The dialogs are new so I don't really know what patterns other gnome apps follow :/

Let me know what you think

IMO dialog should be bigger to fit it's content without scrolling

Not really possible, the content height could be very high based on the amount of keywords, and is definitely bigger than most typical window sizes

@nekohayo
Copy link

In case some of the tricks here are useful, for dynamically figuring out the needed height, see this article.

In an ideal world, I'd recommend a UI that adapts on the desktop to use wider windows, with contents of that dialog being separated into multiple columns to make use of the generous amount of horizontal space on a landscape computer display, but I understand that this would be an effort that may complexify the code…

@GeopJr
Copy link
Owner

GeopJr commented Mar 26, 2024

I don't think a multi column to single column adaptive layout can be easily implemented. There are many edge cases with widget sizing and whatnot. Looking for example at Newsflash, which has 3 'columns', to get around it, it uses multiple nested split layouts 🤷

I can do multiple pages, like the preferences dialog, if there's too much on the filter edit one. "General", "Contexts", "Keywords"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants