improvement: Improve genezio addClass output #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this @andreia-oca |
andreia-oca
requested changes
Mar 27, 2024
src/commands/addClass.ts
Outdated
| @@ -40,7 +40,9 @@ export async function addClassCommand(classPath: string, classType: string) { | |||
| const classExtension = className.split(".").pop(); | |||
|
|
|||
| if (!classExtension || className.split(".").length < 2) { | |||
| throw new UserError("Please provide a class name with a valid class extension."); | |||
| throw new UserError( | |||
| "Please provide a class name with a valid class extension (.ts, .js, or .dart.", | |||
There was a problem hiding this comment.
Please, do not hardcode these values here.
We keep adding support for more programming languages and it would be hard to maintain this piece of code if it's harcoded.
You can use and parse these list [1] of supported extensions to form the error message.
[1] https://github.com/Genez-io/genezio/blob/main/src/utils/languages.ts#L2
|
Hey @andreia-oca |
andreia-oca
approved these changes
Apr 10, 2024
andreia-oca
reviewed
Apr 10, 2024
| @@ -40,7 +40,9 @@ export async function addClassCommand(classPath: string, classType: string) { | |||
| const classExtension = className.split(".").pop(); | |||
|
|
|||
| if (!classExtension || className.split(".").length < 2) { | |||
| throw new UserError("Please provide a class name with a valid class extension."); | |||
| throw new UserError( | |||
| `Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`, | |||
There was a problem hiding this comment.
Suggested change
| `Please provide a class name with a valid class extension. Currently supporting:${supportedExtensionsString}`, | |
| `Please provide a class name with a valid class extension. Currently supporting: ${supportedExtensions}`, |
There was a problem hiding this comment.
It seems that supportedExtensionsString is not declared, I think you want to use supportedExtensions instead. Feel free to commit my suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
This PR improves Genezio addClass output
Checklist