This is just to trigger a build with AWS credentials

Ready for review

Addresses the feedback, tested and verified to work locally. @nick-mon1

This pull request also contains the fix for this Security Issue

https://github.com/GSA/digitalgov.gov/security/dependabot/43

$ npm list lodash.trim
[email protected] /home/riley/programming/digitalgov.gov
└── (empty)

I'll dive into this tomorrow. Thanks @mejiaj

@RileySeaburg

I've updated my .env file with the new key names.

Following the testing steps in description:

How To Test

1. Add an image(s) and static file to /content/uploads
2. Run npm gulp upload
   3.Upload to S3 after processing

I get the following error:

➜ npx gulp upload
[15:25:36] Using gulpfile ~/web/digitalgov.gov/gulpfile.js
[15:25:36] Starting 'upload'...
[15:25:36] Starting 'fileTidy'...
[15:25:36] Finished 'fileTidy' after 383 μs
[15:25:36] Starting 'cleanInbox'...
[15:25:36] Finished 'cleanInbox' after 4.53 ms
[15:25:36] Starting 'writeDataFile'...
[15:25:36] Finished 'writeDataFile' after 6.52 ms
[15:25:36] Starting 'processImages'...
[15:25:36] Finished 'processImages' after 228 μs
[15:25:36] Starting 'removeProcessedImage'...
Removing processed images
No images to process
Error processing file: [undefined]. ENOENT: no such file or directory, scandir './content/uploads/_working-images/to-process'
[15:25:36] Finished 'removeProcessedImage' after 882 μs
[15:25:36] Starting 'uploadImage'...
[15:25:36] Finished 'uploadImage' after 3.62 ms
[15:25:36] Starting 'uploadFile'...
[15:25:36] Finished 'uploadFile' after 1.08 ms
[15:25:36] Starting 'cleanup'...
cleanup
[15:25:36] Finished 'cleanup' after 990 μs
[15:25:36] Finished 'upload' after 20 ms

The image needs to be in /content/uploads/_inbox. That runs successfully:

➜ npx gulp upload
[15:29:23] Using gulpfile ~/web/digitalgov.gov/gulpfile.js
[15:29:23] Starting 'upload'...
[15:29:23] Starting 'fileTidy'...
[15:29:23] Finished 'fileTidy' after 380 μs
[15:29:23] Starting 'cleanInbox'...
[15:29:23] Finished 'cleanInbox' after 5.78 ms
[15:29:23] Starting 'writeDataFile'...
[15:29:23] Finished 'writeDataFile' after 9.38 ms
[15:29:23] Starting 'processImages'...
[15:29:23] Finished 'processImages' after 234 μs
[15:29:23] Starting 'removeProcessedImage'...
Removing processed images
[15:29:23] Finished 'removeProcessedImage' after 2.7 ms
[15:29:23] Starting 'uploadImage'...
file is written
[15:29:24] [create] test-dg-s3-upload-pr-7498.png
[15:29:24] [create] test-dg-s3-upload-pr-7498_w200.png
[15:29:24] [create] test-dg-s3-upload-pr-7498_w400.png
[15:29:25] [create] test-dg-s3-upload-pr-7498_w800.png
[15:29:25] Finished 'uploadImage' after 1.42 s
[15:29:25] Starting 'uploadFile'...
[15:29:25] Finished 'uploadFile' after 3.25 ms
[15:29:25] Starting 'cleanup'...
cleanup
[15:29:25] Finished 'cleanup' after 3.8 ms
[15:29:25] Finished 'upload' after 1.45 s

Unfortunately, I still don't see my files in the S3 bucket.

Hey @mejiaj.
I was under the impression images to be uploaded should be dropped in

content/uploads/_inbox/__add image or static files to this folder__

Should we be putting them in

content/uploads/

@mejiaj I did manage to find you uploads.
In order to use the search box on S3 for some reason you need to type it out from left to right.
I was able to reproduce the not found issue by doing a partial search but they are there.

@RileySeaburg I added some fixes for uploading files. I was able to successfully upload an file:

[10:15:58] Using gulpfile ~/Documents/gsa/digitalgov.gov/gulpfile.js
[10:15:58] Starting 'upload'...
[10:15:58] Starting 'fileTidy'...
[10:15:58] Finished 'fileTidy' after 571 μs
[10:15:58] Starting 'cleanInbox'...
[10:15:58] Finished 'cleanInbox' after 11 ms
[10:15:58] Starting 'writeDataFile'...
[10:15:58] Finished 'writeDataFile' after 25 ms
[10:15:58] Starting 'processImages'...
[10:15:58] Finished 'processImages' after 290 μs
[10:15:58] Starting 'removeProcessedImage'...
Removing processed images
No images to process
Error processing file: [undefined]. ENOENT: no such file or directory, scandir './content/uploads/_working-images/to-process'
[10:15:58] Finished 'removeProcessedImage' after 1.96 ms
[10:15:58] Starting 'uploadImage'...
[10:15:58] Finished 'uploadImage' after 7.78 ms
[10:15:58] Starting 'uploadFile'...
file is written
(node:41977) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
[10:16:10] [create] static/s3-test-uswds-monthly-call-may-2024.pptx
[10:16:11] Finished 'uploadFile' after 12 s
[10:16:11] Starting 'cleanup'...
cleanup
[10:16:11] Finished 'cleanup' after 5.42 ms
[10:16:11] Finished 'upload' after 12 s

Give this a quick test and then I can approve.

@nick-mon1 I got a successful file upload and a consistent file name.