Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8px grids & layout grids? #20

Open
GBKS opened this issue Jan 20, 2023 · 2 comments
Open

8px grids & layout grids? #20

GBKS opened this issue Jan 20, 2023 · 2 comments

Comments

@GBKS
Copy link
Owner

GBKS commented Jan 20, 2023

Do we want to switch to an 8px grid? Currently, the system is based on multiples of 5. So essentially we're shrinking the grid unit by 20%, but the bigger part is to ensure all components more strictly adhere to this.

@stackingsaunter
Copy link

I wanted to do a 8px fork of Bitcoin UI kit :)

Would be happy to start this and perhaps use more advanced components feature

@GBKS
Copy link
Owner Author

GBKS commented Sep 4, 2023

You're welcome to do that. Just want to share my thoughts on why I think it's a bit of a futile task.

  • Pixels in Figma don't translate 1:1 to pixels in code. For example, spacing of text fields is often different. So you might specify 4px padding in Figma, but have to use 7px when coding in CSS, 5 px in Swift, etc.
  • I find it better to think of designs as dynamic and responsive. For example, I often use a CSS technique where the header font size is dynamically calculated based on the screen width (with a minimum and maximum). Same with padding and a handful of other properties. That creates a really nice effect and looks great across screen sizes, but breaks some of the ideas around pixel-unit-specific designs. Whenever I take public transport or travel, I also see a lot of people with custom font/UI sizes based on their accessibility settings, which also breaks this idea.
  • Is this a good thing to spend a ton of time on? If you think so, awesome. For me personally, there is very limited reward and I find it more important to spend that time on other things like copy, flows, etc.

That's just my opinion. The world is your oyster, do as you please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants