Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Pico's Explosion Game Over Song Doesn't Loop #2900

Open
Beelijah opened this issue Jun 24, 2024 · 8 comments
Open

Bug Report: Pico's Explosion Game Over Song Doesn't Loop #2900

Beelijah opened this issue Jun 24, 2024 · 8 comments
Labels
status: pending triage Involves a bug which has not been reviewed yet.

Comments

@Beelijah
Copy link

Describe the bug

When playing the song 2Hot in Weekend 1, there is a secret death song for being exploded.
However, when the song loops, it abruptly ends, and then slowly fades in again.

To Reproduce

literally die to an explosion and wait till the loop

Expected behavior

For the song to not abruptly end
OR
After that song ends, to play the regular song (the song without the fade in)

Screenshots/Video

youtube.com/watch=you-should-see-my-other-issue

Desktop

  • OS: Windows 11

  • Browser: Opera GX (should work on any build though)

  • Version: 0.3.2 to 0.4.1 (including all inbetween)

Additional context

none

@Beelijah
Copy link
Author

Whoops! Meant to put Edge as the browser! Shouldn't matter anyways, it works on any build.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 24, 2024

Good catch!
This should be an easy fix, so I'll take a look at the code.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 25, 2024

Just took a look, and the issue is a bit more complicated than I first thought.

image
^^^
This function in 2hot's scripts handles Pico's explosion death music and animation.

image
^^^
This function seems like it should handle looping fnf_loss_sfx-suffix rather than gameOverStart-suffix

I've replicated and recorded the bug here:

2hot.gameover.fade.in.bug.mp4

@Beelijah
Copy link
Author

Beelijah commented Jun 25, 2024

the comment "this code is jank as hell" lol

i dont know any C, but i know my ways kinda

onComplete (function after completion)
play picodeath (regular death)

one thing to note is that during the fade in if you press retry the retry sound isn't faded in either but that doesn't matter that much

@Beelijah
Copy link
Author

Beelijah commented Jun 25, 2024

also they need to give you a raise/pay you if you aren't already because you have been fixing issues left and right

and if you have time, i have two other issues

edit: 4 more issues

@Hundrec
Copy link
Contributor

Hundrec commented Jun 25, 2024

It's alright, I do this for fun!
I don't know how to code, but I'm happy to help however I can.

@EliteMasterEric EliteMasterEric added the status: pending triage Involves a bug which has not been reviewed yet. label Jun 25, 2024
@Average-FNF-Modder
Copy link

It's alright, I do this for fun! I don't know how to code, but I'm happy to help however I can.

No dude you are literally the Github guy at this point you literal handle so much of their stuff and do it so professionally they should pay you bro you deserve it at this point. You like an under the counter hire my guy 😭

@Beelijah
Copy link
Author

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Involves a bug which has not been reviewed yet.
Projects
None yet
Development

No branches or pull requests

4 participants