Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: BG Music stays playing if music is muted. #2878

Open
Average-FNF-Modder opened this issue Jun 21, 2024 · 2 comments
Open

Enhancement: BG Music stays playing if music is muted. #2878

Average-FNF-Modder opened this issue Jun 21, 2024 · 2 comments
Labels
status: pending triage Involves a bug which has not been reviewed yet.

Comments

@Average-FNF-Modder
Copy link

What is your suggestion, and why should it be implemented?

Pretty simple, if all audio tracks that were added to the chart are muted, than the BG music should keep playing in the background if spacebar is hit to play the song.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 21, 2024

This suggestion sounds intuitive, but I'm having trouble thinking of cases where someone would want this to happen.

If I've muted all the tracks in the chart, then I might be seeing how the chart's note patterns flow.
In this case, I would rather have Artistic Expression muted so I can focus on the rhythms of the chart rather than the BGM.

Of course, the theme could easily be toggled from the context menu, but it seems like an unfavorable compromise to have to turn off the theme globally just to focus on the chart.

@Average-FNF-Modder
Copy link
Author

This suggestion sounds intuitive, but I'm having trouble thinking of cases where someone would want this to happen.

If I've muted all the tracks in the chart, then I might be seeing how the chart's note patterns flow. In this case, I would rather have Artistic Expression muted so I can focus on the rhythms of the chart rather than the BGM.

Of course, the theme could easily be toggled from the context menu, but it seems like an unfavorable compromise to have to turn off the theme globally just to focus on the chart.

I just don't think it would really bother me at all to have it in the background. Maybe it would bother some people, so it could be an option or something to have my idea on or not.

@EliteMasterEric EliteMasterEric added the status: pending triage Involves a bug which has not been reviewed yet. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Involves a bug which has not been reviewed yet.
Projects
None yet
Development

No branches or pull requests

3 participants