Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Improve offsets for timing judgements #2877

Open
JackXson-Real opened this issue Jun 21, 2024 · 3 comments
Open

Enhancement: Improve offsets for timing judgements #2877

JackXson-Real opened this issue Jun 21, 2024 · 3 comments
Labels
status: pending triage Involves a bug which has not been reviewed yet.

Comments

@JackXson-Real
Copy link

Currently getting a sick rating feels really luck based for me since it's a little bit off. You are able to click an arrow pretty early and get a sick, but clicking it when the arrow is just a tiny bit above the strumline causes it to be just a good. Even though I play the song perfectly on beat, I somehow manage to almost always get 1 or 2 goods due to this issue. I recommend giving a little more leeway when hitting notes a little bit later so that its the same as hitting a note early. I mainly used Psych Engine to play the game before the update came out, and the judgements for sick rating on there feels more consistent than in base game currently. The difference between that and base game is like night and day. I highly recommend making it similar to Psych Engine so that getting a golden P rank for songs is a lot less painful and more consistent.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 21, 2024

The generous early window and unforgiving late window might just be due to your hardware's input latency. My laptop has around a 30 ms delay, which can sometimes make the difference between Sick and Good.

You can try applying an offset using the input offset menu from Options.

@JackXson-Real
Copy link
Author

JackXson-Real commented Jun 22, 2024

The generous early window and unforgiving late window might just be due to your hardware's input latency. My laptop has around a 30 ms delay, which can sometimes make the difference between Sick and Good.

You can try applying an offset using the input offset menu from Options.

Thats not the issue. That solves audio delay. The issue this addresses is that you are given more leeway when pressing early than pressing late. It should be the same amount of time. I recommend playing a song both on base game and psych engine, and you will see the difference is night and day.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 22, 2024

I still believe this is an input latency issue.
The game's code specifies hit windows based on percentages. Unless there's another section of code offsetting the window, it's treating early and late inputs equally.

image

@EliteMasterEric EliteMasterEric added the status: pending triage Involves a bug which has not been reviewed yet. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Involves a bug which has not been reviewed yet.
Projects
None yet
Development

No branches or pull requests

3 participants