Improve conversions of types in the std lib #5797

SwayStar123 · 2024-03-28T07:59:54Z

There are many missing pairs of conversions that are possible but not implemented in the standard library, aswell as some non trait implementations which are duplicates of their trait implementation counterparts.

Remove duplicate functions

There are implementations such as

impl u16 {
    pub fn try_as_u8(self) -> Option<u8> {
        if self <= u8::max().as_u16() {
            Some(asm(input: self) {
                input: u8
            })
        } else {
            None
        }
    }
}

which serve to attempt conversion of a u16 to a u8, however, there is already an implementation of

impl TryFrom<u16> for u8 {
    fn try_from(u: u16) -> Option<Self> {
        if u > u8::max().as_u16() {
            None
        } else {
            Some(asm(r1: u) {
                r1: u8
            })
        }
    }
}

which serves the same purpose, and with the generic auto implementation of TryInto via

impl<T, U> TryInto<U> for T
where
    U: TryFrom<T>,
{
    fn try_into(self) -> Option<U> {
        U::try_from(self)
    }
}

renders the try_as_* functions redundant.

The text was updated successfully, but these errors were encountered:

## Description Adds From<u8> for u16 Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <[email protected]>

## Description Adds implementation for From<u8> and From<u16> for u32 Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

## Description Adds implementations for From<u8>, From<u16>, From<u32> for u64 Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

## Description Adds impl From<u8,u16,u32,u64> for U128 Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: Cameron Carstens <[email protected]> Co-authored-by: K1-R1 <[email protected]>

## Description Implements From< U128 > for u256, b256 Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.

## Description Implements TryFrom< U128 > for <u64,u32,u16,u8> Partially addresses #5797 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.

SwayStar123 added lib: std Standard library code quality breaking May cause existing user code to break. Requires a minor or major release. P: medium labels Mar 28, 2024

SwayStar123 self-assigned this Mar 28, 2024

SwayStar123 changed the title ~~Revamp and add conversions to standard library~~ Improve conversions of types in the std lib Mar 28, 2024

This was referenced Mar 28, 2024

Add u256 conversions #5767

Merged

Remove duplicate functions from conversions library #5800

Draft

From<u8> for u16 implementation #5815

Merged

From<u8, u16> for u32 #5816

Merged

From<u8, u16, u32> for u64 implementations #5817

Merged

SwayStar123 mentioned this issue Apr 3, 2024

Allow conversions between native u types and U128 #5825

Merged

8 tasks

bitzoic mentioned this issue Apr 4, 2024

Missing U128 conversions #5821

Closed

This was referenced Apr 22, 2024

Implement From< U128 > for u256, b256 #5887

Merged

Implement TryFrom< U128 > for all primitive u types #5888

Merged

SwayStar123 mentioned this issue May 14, 2024

TryFrom< B512 > for b256, u256 #6010

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve conversions of types in the std lib #5797

Improve conversions of types in the std lib #5797

SwayStar123 commented Mar 28, 2024 •

edited

Improve conversions of types in the std lib #5797

Improve conversions of types in the std lib #5797

Comments

SwayStar123 commented Mar 28, 2024 • edited

Remove duplicate functions

SwayStar123 commented Mar 28, 2024 •

edited