Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run Release action on release/* branch creation #2215

Closed
nedsalk opened this issue Apr 30, 2024 · 0 comments · Fixed by #2216
Closed

Do not run Release action on release/* branch creation #2215

nedsalk opened this issue Apr 30, 2024 · 0 comments · Fixed by #2216
Assignees

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Apr 30, 2024

Currently the Release workflow runs when a release/* branch is created, which doesn't make sense because it already ran once beforehand when that branch's commit was released. This might give us problems because the Release workflow is critical to publishing and docs.

Two solutions come to mind, in order of preference:

  1. Handle it via github events via some "on:push && not-on:create" logic
  2. Have a step to stop the workflow if the ref_name is release* and its commit matches the corresponding tag's commit.
@nedsalk nedsalk changed the title Do not run action on release/* branch creation Do not run Release action on release/* branch creation Apr 30, 2024
@nedsalk nedsalk self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant