Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure changeset PR deletes all changesets #2067

Closed
nedsalk opened this issue Apr 16, 2024 · 0 comments · Fixed by #2166
Closed

Ensure changeset PR deletes all changesets #2067

nedsalk opened this issue Apr 16, 2024 · 0 comments · Fixed by #2166
Assignees
Labels

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Apr 16, 2024

The release/publish behavior upon merging of a changeset PR into its base branch relies on it deleting all changeset files in the .changeset folder. If a changeset file is erroneously not deleted, the release/publish won't happen; take #2065 as an example.

We should make sure that the changeset PR deletes all changesets. If it doesn't, it shouldn't be mergable into its base branch. Besides workflow changes, this might require additional repository rules for changeset-release/* branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant