Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add relative link lint for lint:md-links #2218

Merged
merged 29 commits into from May 15, 2024
Merged

chore: add relative link lint for lint:md-links #2218

merged 29 commits into from May 15, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented May 1, 2024 •
edited

Closes #2141

  • Added linting for markdown anchor links (#example)
  • Moved CI linting to a separate workflow (code-lint) and removed markdown-link-check workflow.

@petertonysmith94 petertonysmith94 self-assigned this May 1, 2024
@petertonysmith94
Copy link
Contributor Author

Added a new @elasticpath/no-dead-relative-link plugin, due to the no-dead-link plugin being limiting for relative links.

I have resolved all the issues that were detected.

Outstanding issues are due to the API docs not being built out at this step.

@petertonysmith94 petertonysmith94 marked this pull request as ready for review May 9, 2024 09:37
@petertonysmith94 @maschad
Update .knip.json
62b8bd9 
Co-authored-by: Chad Nehemiah <[email protected]>
@petertonysmith94 petertonysmith94 dismissed stale reviews from danielbate and maschad via 62b8bd9 May 14, 2024 10:59
danielbate
danielbate previously approved these changes May 14, 2024
View reviewed changes
maschad
maschad previously approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this but we should do some follow-up work in #1835 (comment)

@petertonysmith94 petertonysmith94 dismissed stale reviews from maschad and danielbate via 8b789ea May 14, 2024 21:08
maschad
maschad previously approved these changes May 14, 2024
View reviewed changes
danielbate
danielbate previously approved these changes May 14, 2024
View reviewed changes
@petertonysmith94
Copy link
Contributor Author

@arboleya we would need the following added as required steps:

  • lint
  • dependency-check

And the following removed:

  • markdown-link-check

@petertonysmith94 petertonysmith94 dismissed stale reviews from maschad and danielbate via 4c53b03 May 15, 2024 10:11
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0.25%) 70.47%(+0.63%) 76.85%(-0.27%) 79.88%(+0.23%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/AbiCoder.ts 75%
(+0%)		 0%
(-100%)		 66.66%
(+0%)		 75%
(+0%)
🔴 packages/abi-coder/src/FunctionFragment.ts 65.38%
(-4.18%)		 60%
(-9.69%)		 71.42%
(-1.91%)		 64.81%
(-4.63%)
🔴 packages/abi-coder/src/Interface.ts 72%
(+0%)		 60%
(-2.5%)		 76.92%
(+0%)		 71.42%
(+0%)
✅ ✨ packages/abi-coder/src/encoding/coders/ArrayCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B256Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B512Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BigNumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BooleanCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/ByteCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/EnumCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/NumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/OptionCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/abi-coder/src/encoding/coders/RawSliceCoder.ts 94.44%
(+94.44%)		 83.33%
(+83.33%)		 100%
(+100%)		 94.44%
(+94.44%)
✅ ✨ packages/abi-coder/src/encoding/coders/StdStringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StrSliceCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StructCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/TupleCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/VecCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/abi-coder/src/encoding/strategies/getCoderV1.ts 91.48%
(-0.18%)		 86.66%
(+0%)		 100%
(+0%)		 91.66%
(+0%)
🔴 packages/abi-coder/src/utils/constants.ts 97.36%
(-0.07%)		 100%
(+0%)		 0%
(+0%)		 97.36%
(-0.07%)
🔴 packages/abi-coder/src/utils/utilities.ts 20%
(-76.49%)		 0%
(-80%)		 50%
(-50%)		 27.27%
(-69.45%)
🔴 packages/account/src/account.ts 82.78%
(-0.22%)		 66.66%
(+0%)		 76%
(+0%)		 82.35%
(-0.23%)
🔴 packages/account/src/mnemonic/utils.ts 97.61%
(+19.15%)		 91.66%
(+28.03%)		 100%
(+0%)		 97.77%
(+18.06%)
🔴 packages/account/src/predicate/predicate.ts 24.19%
(+1.81%)		 31.25%
(+0%)		 13.33%
(+0.83%)		 23.07%
(+1.65%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 85.91%
(+0.4%)		 75%
(+2.17%)		 86%
(-0.53%)		 86.3%
(+0.4%)
🔴 packages/account/src/providers/transaction-summary/call.ts 6.25%
(+1.49%)		 0%
(+0%)		 0%
(+0%)		 6.25%
(+1.49%)
🔴 packages/create-fuels/src/cli.ts 87.8%
(-0.43%)		 60.52%
(+0%)		 100%
(+0%)		 88.23%
(-0.4%)
✅ ✨ packages/create-fuels/src/lib/setupProgram.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/program/src/contract-call-script.ts 10.97%
(+0.14%)		 0%
(+0%)		 0%
(+0%)		 10.58%
(+0.02%)
🔴 packages/program/src/functions/multicall-scope.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/utils/src/utils/toUtf8Bytes.ts 88%
(+88%)		 84.61%
(+84.61%)		 100%
(+100%)		 88.46%
(+88.46%)
🔴 ✨ packages/utils/src/utils/toUtf8String.ts 94.64%
(+94.64%)		 92.3%
(+92.3%)		 100%
(+100%)		 94.73%
(+94.73%)

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) May 15, 2024 12:15
@petertonysmith94 petertonysmith94 merged commit 6c2be7f into master May 15, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/linting-markdown-links branch May 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown validation not validating markdown link fragments
4 participants
@petertonysmith94 @arboleya @danielbate @maschad