Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Value Conflicts #79

Open
csharpfritz opened this issue Feb 12, 2020 · 4 comments
Open

Attribute Value Conflicts #79

csharpfritz opened this issue Feb 12, 2020 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@csharpfritz
Copy link
Contributor

from @grleachman in #21

Attribute Value Conflicts

Adding RepeatDirection has caused a conflict with GridLines

There's now an ugly problem where the static enums require the markup to be messy:

Gridlines="Enums.GridLines.Horizontal"
RepeatDirection="Enums.RepeatDirection.Horizontal"

This is going to be painful for migration.

@csharpfritz csharpfritz added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Feb 12, 2020
@hishamco
Copy link
Collaborator

I think the better way to fix this is not using Enums namespace? I can file an issue regarding namespace change suggestion that may make the migration so simple

@hishamco
Copy link
Collaborator

Is there a reason to declare enum as abstract class?

@csharpfritz
Copy link
Contributor Author

csharpfritz commented Feb 23, 2020 via email

@hishamco
Copy link
Collaborator

Is this working fine?

Gridlines="GridLines.Horizontal"
RepeatDirection="RepeatDirection.Horizontal"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants